You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/01 20:22:18 UTC

[GitHub] [beam] jonathanasdf opened a new issue, #22547: [Feature Request][python]: Better typing support for TimestampedValue

jonathanasdf opened a new issue, #22547:
URL: https://github.com/apache/beam/issues/22547

   ### What would you like to happen?
   
   Currently transforms that return a TimestampedValue need to be typed as plain "TimestampedValue" rather than generic "TimestampedValue[T]" so all underlying information about what type is being wrapped is lost.
   
   ### Issue Priority
   
   Priority: 3
   
   ### Issue Component
   
   Component: sdk-py-core


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] jonathanasdf commented on issue #22547: [Feature Request][python]: Better typing support for TimestampedValue

Posted by GitBox <gi...@apache.org>.
jonathanasdf commented on issue #22547:
URL: https://github.com/apache/beam/issues/22547#issuecomment-1209722906

   Sorry - yes that is a good rephrasing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] jrmccluskey closed issue #22547: [Feature Request][python]: Better typing support for TimestampedValue

Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey closed issue #22547: [Feature Request][python]: Better typing support for TimestampedValue
URL: https://github.com/apache/beam/issues/22547


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] TheNeuralBit commented on issue #22547: [Feature Request][python]: Better typing support for TimestampedValue

Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on issue #22547:
URL: https://github.com/apache/beam/issues/22547#issuecomment-1209715440

   Let me re-state to make sure I understand the ask. You're saying that TimestampValue is _not_ a generic type, but it should be?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] TheNeuralBit commented on issue #22547: [Feature Request][python]: Better typing support for TimestampedValue

Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on issue #22547:
URL: https://github.com/apache/beam/issues/22547#issuecomment-1209801783

   Got it, I think this would be a relatively straightforward change - just refactor TimestampedValue to inherit from Generic. In order for it to have an effect on beam typehints, we'd also want to adjust `DoFn.default_type_hints` to extract the element type from the generic TimestampedValue (and we should do the same for WindowedValue).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] liferoad commented on issue #22547: [Feature Request][python]: Better typing support for TimestampedValue

Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on issue #22547:
URL: https://github.com/apache/beam/issues/22547#issuecomment-1504062365

   .take-issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org