You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "avano (via GitHub)" <gi...@apache.org> on 2023/04/28 06:52:17 UTC

[GitHub] [camel-quarkus] avano commented on a diff in pull request #4838: [MapStruct] Add tests

avano commented on code in PR #4838:
URL: https://github.com/apache/camel-quarkus/pull/4838#discussion_r1179997912


##########
integration-tests-jvm/mapstruct/pom.xml:
##########
@@ -37,17 +37,21 @@
             <groupId>org.apache.camel.quarkus</groupId>
             <artifactId>camel-quarkus-mapstruct</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.apache.camel.quarkus</groupId>
+            <artifactId>camel-quarkus-direct</artifactId>
+        </dependency>
+
         <dependency>
             <groupId>io.quarkus</groupId>
             <artifactId>quarkus-resteasy</artifactId>
         </dependency>
-
-        <!-- test dependencies -->
         <dependency>
             <groupId>io.quarkus</groupId>
             <artifactId>quarkus-junit5</artifactId>
-            <scope>test</scope>

Review Comment:
   thanks, I was checking out how similar components are doing this and found [this](https://github.com/apache/camel-quarkus/blob/main/integration-tests/bindy/src/main/java/org/apache/camel/quarkus/component/bindy/it/BindyResource.java#L68) so I took the inspiration from there :grin: 
   
   I'll rework according to your comments



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org