You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/04 05:23:39 UTC

[GitHub] [arrow] nevi-me commented on a change in pull request #9412: ARROW-11491: [Rust] support JSON schema inference for nested list and struct

nevi-me commented on a change in pull request #9412:
URL: https://github.com/apache/arrow/pull/9412#discussion_r569954389



##########
File path: rust/arrow/test/data/mixed_arrays.json
##########
@@ -1,4 +1,4 @@
-{"a":1, "b":[2.0, 1.3, -6.1], "c":[false, true], "d":4.1}
+{"a":1, "b":[2.0, 1.3, -6.1], "c":[false, true], "d":["4.1"]}
 {"a":-10, "b":[2.0, 1.3, -6.1], "c":null, "d":null}
-{"a":2, "b":[2.0, null, -6.1], "c":[false, null], "d":"text"}
-{"a":3, "b":4, "c": true, "d":[1, false, "array", 2.4]}
+{"a":2, "b":[2.0, null, -6.1], "c":[false, null], "d":["text"]}
+{"a":3, "b":[], "c": [], "d":["array"]}

Review comment:
       There aim was to reduce the odds of throwing away data, converting the scalar to a single-item list.
   
   I can't remember if I checked against Spark, but I'll do that during the day. I'm convinced that I've come across the behaviour elsewhere before, but can't remember where.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org