[jira] [Commented] (HBASE-10012) Hide ServerName constructor

["Jonathan Hsieh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850428#comment-13850428 ] 

Jonathan Hsieh commented on HBASE-10012:
----------------------------------------

Just noticed this -- it breaks API compat between 0.94->0.96.1 and 0.96.0->0.96.1 without going through deprecation. (see HBASE-10186). 

http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/ServerName.html

Can we make make the ServerName constructor public and deprecated in 0.96.1 and the 0.96.x branch?  We possibly should do a quick 0.96.1.1 release to fix this compat contract breaking issue.

> Hide ServerName constructor
> ---------------------------
>
>                 Key: HBASE-10012
>                 URL: https://issues.apache.org/jira/browse/HBASE-10012
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.98.0, 0.96.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>            Priority: Minor
>             Fix For: 0.98.0, 0.96.1
>
>         Attachments: 10012.v1.096.patch, 10012.v1.patch
>
>
> If we want to share the instances of ServerName, we need to hide the constructor, and do as we do in TableName.
> This patch is just about the refactoring of "new ServerName" to ServerName.valueOf, to make its review simpler.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)