You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "SBIN2010 (via GitHub)" <gi...@apache.org> on 2026/08/17 22:00:40 UTC
[PR] feat(dashboard): add a tooltip displaying chart descriptions [superset]
SBIN2010 opened a new pull request, #43271:
URL: https://github.com/apache/superset/pull/43271
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR adds a tooltip for charts on the dashboard, displaying the description if one has been provided for the chart.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
<img width="886" height="582" alt="Снимок экрана от 2026-08-18 00-10-04" src="https://github.com/user-attachments/assets/1ca8955e-0540-4ab7-ac3b-bfec95c21973" />
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
run test:
npm run test superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): add a tooltip displaying chart descriptions [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43271:
URL: https://github.com/apache/superset/pull/43271#issuecomment-5320807483
<!-- Bito Reply -->
The flagged issue is correct. Using `trigger="hover"` on a `Popover` makes the chart description inaccessible on touch-based mobile devices. To resolve this, you should change the trigger to `click` or support both `hover` and `click` (if the component library allows) to ensure mobile users can open the description.
Here is the suggested fix for `superset-frontend/src/dashboard/components/SliceHeader/index.tsx`:
```tsx
{slice.description && !isExpanded && (
<Popover
trigger={['hover', 'click']}
content={<SliceInfo slice={slice} />}
placement="leftBottom"
>
<Icons.InfoCircleOutlined
iconSize="m"
aria-label={t('Chart description')}
data-test="chart-description-info-icon"
/>
</Popover>
)}
```
I have checked the PR comments, and there are no other comments to address at this time. Would you like me to perform any further checks or implement additional changes?
**superset-frontend/src/dashboard/components/SliceHeader/index.tsx**
```
<Popover
trigger={['hover', 'click']}
content={<SliceInfo slice={slice} />}
placement="leftBottom"
>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): add a tooltip displaying chart descriptions [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #43271:
URL: https://github.com/apache/superset/pull/43271#discussion_r3799153130
##########
superset-frontend/src/dashboard/components/SliceHeader/index.tsx:
##########
@@ -335,6 +341,19 @@ const SliceHeader = forwardRef<HTMLDivElement, SliceHeaderProps>(
<CrossFilterIcon iconSize="m" />
</Tooltip>
)}
+ {slice.description && !isExpanded && (
+ <Popover
+ trigger="hover"
+ content={<SliceInfo slice={slice} />}
+ placement="leftBottom"
Review Comment:
**Suggestion:** The new description Popover is rendered in mobile mode, but its only trigger is `hover`, which is not available on touch devices. Mobile users therefore see an extra info icon but cannot open the chart description. Either provide a touch-compatible trigger or suppress this control on mobile. [logic error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Mobile users cannot reliably view chart descriptions.
- ⚠️ Description icon remains visible but non-functional.
- ⚠️ Affects mobile dashboard chart consumption.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=55afe80ce3d4466a8e3589e539d33ba4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=55afe80ce3d4466a8e3589e539d33ba4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/dashboard/components/SliceHeader/index.tsx
**Line:** 344:348
**Comment:**
*Logic Error: The new description Popover is rendered in mobile mode, but its only trigger is `hover`, which is not available on touch devices. Mobile users therefore see an extra info icon but cannot open the chart description. Either provide a touch-compatible trigger or suppress this control on mobile.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43271&comment_hash=bf6e4426f04f037953e10138184bbb4ccd7a0817970b371e969c2015afd64d9d&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43271&comment_hash=bf6e4426f04f037953e10138184bbb4ccd7a0817970b371e969c2015afd64d9d&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): add a tooltip displaying chart descriptions [superset]
Posted by "SBIN2010 (via GitHub)" <gi...@apache.org>.
SBIN2010 commented on code in PR #43271:
URL: https://github.com/apache/superset/pull/43271#discussion_r3886796424
##########
superset-frontend/src/dashboard/components/SliceHeader/index.tsx:
##########
@@ -335,6 +341,19 @@ const SliceHeader = forwardRef<HTMLDivElement, SliceHeaderProps>(
<CrossFilterIcon iconSize="m" />
</Tooltip>
)}
+ {slice.description && !isExpanded && (
+ <Popover
+ trigger={['hover', 'click']}
+ content={<SliceInfo slice={slice} />}
+ placement="leftBottom"
+ >
+ <Icons.InfoCircleOutlined
+ iconSize="m"
+ aria-label={t('Chart description')}
+ data-test="chart-description-info-icon"
+ />
+ </Popover>
+ )}
Review Comment:
@rusackas
Thanks for the recommendations; I’ve applied them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): add a tooltip displaying chart descriptions [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #43271:
URL: https://github.com/apache/superset/pull/43271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): add a tooltip displaying chart descriptions [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43271:
URL: https://github.com/apache/superset/pull/43271#issuecomment-5322213488
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): add a tooltip displaying chart descriptions [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #43271:
URL: https://github.com/apache/superset/pull/43271#discussion_r3885475017
##########
superset-frontend/src/dashboard/components/SliceHeader/index.tsx:
##########
@@ -335,6 +341,19 @@ const SliceHeader = forwardRef<HTMLDivElement, SliceHeaderProps>(
<CrossFilterIcon iconSize="m" />
</Tooltip>
)}
+ {slice.description && !isExpanded && (
+ <Popover
+ trigger={['hover', 'click']}
+ content={<SliceInfo slice={slice} />}
+ placement="leftBottom"
+ >
+ <Icons.InfoCircleOutlined
+ iconSize="m"
+ aria-label={t('Chart description')}
+ data-test="chart-description-info-icon"
+ />
+ </Popover>
+ )}
Review Comment:
Suggested fix for the keyboard-accessibility gap copilot flagged: `Icons.InfoCircleOutlined` has no `tabIndex`/keydown handling on its own, so keyboard users can't reach the click trigger. Matches the controlled-Popover pattern `DrillBySubmenu.tsx` uses plus `handleKeyboardActivation` from `ControlHeader.tsx`, both already established in this codebase.
Two other one-line changes needed alongside this (outside this hunk, so not apply-able here):
Add `handleKeyboardActivation` to the existing `@superset-ui/core` import near the top of the file:
```tsx
import {
getExtensionsRegistry,
handleKeyboardActivation,
JsonObject,
QueryData,
VizType,
} from '@superset-ui/core';
```
Add a bit of open/close state next to the existing `headerTooltip` state:
```tsx
const [isDescriptionOpen, setIsDescriptionOpen] = useState(false);
```
```suggestion
{slice.description && !isExpanded && (
<Popover
trigger={['hover', 'click']}
content={<SliceInfo slice={slice} />}
placement="leftBottom"
open={isDescriptionOpen}
onOpenChange={setIsDescriptionOpen}
>
<Icons.InfoCircleOutlined
iconSize="m"
role="button"
tabIndex={0}
aria-label={t('Chart description')}
data-test="chart-description-info-icon"
onKeyDown={handleKeyboardActivation(() =>
setIsDescriptionOpen(open => !open),
)}
/>
</Popover>
)}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): add a tooltip displaying chart descriptions [superset]
Posted by "SBIN2010 (via GitHub)" <gi...@apache.org>.
SBIN2010 commented on PR #43271:
URL: https://github.com/apache/superset/pull/43271#issuecomment-5331922264
> @SBIN2010 for the tooltips we may want to make sure there are translations for them too.
@sadpandajoe The tooltip displays the chart description; I don't think it will need translation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): add a tooltip displaying chart descriptions [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #43271:
URL: https://github.com/apache/superset/pull/43271#discussion_r3890302968
##########
superset-frontend/src/dashboard/components/SliceHeader/index.tsx:
##########
@@ -335,6 +341,19 @@ const SliceHeader = forwardRef<HTMLDivElement, SliceHeaderProps>(
<CrossFilterIcon iconSize="m" />
</Tooltip>
)}
+ {slice.description && !isExpanded && (
+ <Popover
+ trigger={['hover', 'click']}
+ content={<SliceInfo slice={slice} />}
+ placement="leftBottom"
+ >
+ <Icons.InfoCircleOutlined
+ iconSize="m"
+ aria-label={t('Chart description')}
+ data-test="chart-description-info-icon"
+ />
+ </Popover>
+ )}
Review Comment:
Verified the suggestion landed as-is, and the new Enter/Space tests cover it. Thanks!
##########
superset-frontend/src/dashboard/components/SliceHeader/index.tsx:
##########
@@ -335,6 +341,19 @@ const SliceHeader = forwardRef<HTMLDivElement, SliceHeaderProps>(
<CrossFilterIcon iconSize="m" />
</Tooltip>
)}
+ {slice.description && !isExpanded && (
+ <Popover
+ trigger={['hover', 'click']}
+ content={<SliceInfo slice={slice} />}
+ placement="leftBottom"
+ >
+ <Icons.InfoCircleOutlined
+ iconSize="m"
+ aria-label={t('Chart description')}
+ data-test="chart-description-info-icon"
+ />
+ </Popover>
+ )}
Review Comment:
This is addressed now... the icon is a controlled Popover trigger with `role="button"`, `tabIndex={0}`, and Enter/Space handling via `handleKeyboardActivation`, with tests covering focus and both keys. Resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): add a tooltip displaying chart descriptions [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #43271:
URL: https://github.com/apache/superset/pull/43271#issuecomment-5320953876
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43271?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 66.66%. Comparing base ([`d114eb6`](https://app.codecov.io/gh/apache/superset/commit/d114eb638b7a10b5e3c7eea78a43ed0019639e7a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9b29e30`](https://app.codecov.io/gh/apache/superset/commit/9b29e30dba6cd39cf706032741c62937389cf2f1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 14 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/43271?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...src/dashboard/components/SliceHeader/SliceInfo.tsx](https://app.codecov.io/gh/apache/superset/pull/43271?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fdashboard%2Fcomponents%2FSliceHeader%2FSliceInfo.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyL1NsaWNlSW5mby50c3g=) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43271?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #43271 +/- ##
==========================================
- Coverage 66.66% 66.66% -0.01%
==========================================
Files 2873 2874 +1
Lines 163654 163660 +6
Branches 37771 37773 +2
==========================================
+ Hits 109093 109096 +3
- Misses 52432 52435 +3
Partials 2129 2129
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/43271/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/43271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.77% <66.66%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43271?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): add a tooltip displaying chart descriptions [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43271:
URL: https://github.com/apache/superset/pull/43271#issuecomment-5320765451
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): add a tooltip displaying chart descriptions [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #43271:
URL: https://github.com/apache/superset/pull/43271#issuecomment-5320781210
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | c6b792da948c0b776508e59309ba00ece614f29b |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a83848856112000080f1521 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-43271--superset-docs-preview.netlify.app](https://deploy-preview-43271--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#q1YqKMrPLShRslJS0lFKKkrMS84AstNSE0v0E1NS4pMzEotK4kvy83NKMguAKlJSC3LyKz1TgGrMEi2MLUwsLEzNDA2NDIDAwiDN0NTIUKkWAA) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-43271--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): add a tooltip displaying chart descriptions [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #43271:
URL: https://github.com/apache/superset/pull/43271#issuecomment-5331743341
@SBIN2010 for the tooltips we may want to make sure there are translations for them too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): add a tooltip displaying chart descriptions [superset]
Posted by "rohys03 (via GitHub)" <gi...@apache.org>.
rohys03 commented on PR #43271:
URL: https://github.com/apache/superset/pull/43271#issuecomment-5336035798
I've been really looking forward to this feature! Being able to add descriptions to charts and show them as tooltips on dashboards would be incredibly useful.
Do you have an estimated timeline for when this feature might be merged and included in a Superset release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): add a tooltip displaying chart descriptions [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #43271:
URL: https://github.com/apache/superset/pull/43271#discussion_r3890303377
##########
superset-frontend/src/dashboard/components/SliceHeader/index.tsx:
##########
@@ -335,6 +341,19 @@ const SliceHeader = forwardRef<HTMLDivElement, SliceHeaderProps>(
<CrossFilterIcon iconSize="m" />
</Tooltip>
)}
+ {slice.description && !isExpanded && (
+ <Popover
+ trigger="hover"
+ content={<SliceInfo slice={slice} />}
+ placement="leftBottom"
Review Comment:
The popover triggers on both hover and click, so touch users can tap the icon to open it. Resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): add a tooltip displaying chart descriptions [superset]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #43271:
URL: https://github.com/apache/superset/pull/43271#discussion_r3876060026
##########
superset-frontend/src/dashboard/components/SliceHeader/index.tsx:
##########
@@ -335,6 +341,19 @@ const SliceHeader = forwardRef<HTMLDivElement, SliceHeaderProps>(
<CrossFilterIcon iconSize="m" />
</Tooltip>
)}
+ {slice.description && !isExpanded && (
+ <Popover
+ trigger={['hover', 'click']}
+ content={<SliceInfo slice={slice} />}
+ placement="leftBottom"
+ >
+ <Icons.InfoCircleOutlined
+ iconSize="m"
+ aria-label={t('Chart description')}
+ data-test="chart-description-info-icon"
+ />
+ </Popover>
+ )}
Review Comment:
The Popover trigger is an icon element, which is not keyboard-focusable. Because the Popover also uses `click` as a trigger, keyboard-only users won’t be able to open the chart description. Wrap the icon in a real `<button>` (or a Superset `Button`) so the trigger is focusable and supports Enter/Space activation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(dashboard): add a tooltip displaying chart descriptions [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43271:
URL: https://github.com/apache/superset/pull/43271#issuecomment-5463467145
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org