You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2019/04/11 23:12:30 UTC

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

Hello Michael Ho, Andrew Sherman, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12297

to look at the new patch set (#4).

Change subject: IMPALA-8138: Reintroduce rpc debugging options
......................................................................

IMPALA-8138: Reintroduce rpc debugging options

In the past, we had fault injection options for backend rpcs
implemented in ImpalaBackendClient. With the move the krpc, we lost
some of those options.

This patch reintroduces equivalent options, except that they now
utilize the existing DebugAction framework, which is more flexible and
powerful than the FAULT_INJECTION framework used previously.

Change-Id: I2046cb9dadf846ea90c04e95781b2bbde3325941
---
A be/src/rpc/impala-control-service-proxy.h
A be/src/rpc/impala-data-stream-service-proxy.h
M be/src/rpc/rpc-mgr-test.cc
M be/src/rpc/rpc-mgr.cc
M be/src/rpc/rpc-mgr.h
M be/src/rpc/rpc-mgr.inline.h
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/krpc-data-stream-sender.cc
M be/src/runtime/query-state.cc
M be/src/runtime/query-state.h
M be/src/service/client-request-state.cc
M be/src/service/control-service.cc
M be/src/service/control-service.h
M be/src/service/data-stream-service.cc
M be/src/service/data-stream-service.h
M be/src/util/CMakeLists.txt
A be/src/util/krpc-debug-util.cc
A be/src/util/krpc-debug-util.h
M tests/custom_cluster/test_restart_services.py
M tests/query_test/test_cancellation.py
20 files changed, 487 insertions(+), 133 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/12297/4
-- 
To view, visit http://gerrit.cloudera.org:8080/12297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2046cb9dadf846ea90c04e95781b2bbde3325941
Gerrit-Change-Number: 12297
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>