You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/27 04:08:05 UTC
[GitHub] [incubator-dolphinscheduler] clay4444 opened a new pull request
#1594: Fix format bug
clay4444 opened a new pull request #1594: Fix format bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1594
# What is the purpose of the pull request
The placeholder for the String.format method is %s instead of {}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1594:
Fix format bug
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1594: Fix format bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1594#issuecomment-569182973
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1594?src=pr&el=h1) Report
> Merging [#1594](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1594?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/026fdd9e1c2fab944776c6cc09716d0b5b185baa?src=pr&el=desc) will **increase** coverage by `1.47%`.
> The diff coverage is `28.24%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1594?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1594 +/- ##
========================================
+ Coverage 7.58% 9.06% +1.47%
========================================
Files 277 283 +6
Lines 13743 13843 +100
Branches 2194 2204 +10
========================================
+ Hits 1043 1255 +212
+ Misses 12631 12495 -136
- Partials 69 93 +24
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1594?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../org/apache/dolphinscheduler/common/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1594/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL0NvbnN0YW50cy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...server/master/runner/SubProcessTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1594/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvU3ViUHJvY2Vzc1Rhc2tFeGVjVGhyZWFkLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...e/dolphinscheduler/common/zk/AbstractZKClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1594/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL0Fic3RyYWN0WktDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [...dolphinscheduler/server/monitor/MonitorServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1594/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvTW9uaXRvclNlcnZlci5qYXZh) | `0% <0%> (ø)` | |
| [...uler/server/worker/log/SensitiveDataConverter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1594/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9sb2cvU2Vuc2l0aXZlRGF0YUNvbnZlcnRlci5qYXZh) | `0% <0%> (ø)` | |
| [...olphinscheduler/server/utils/SensitiveLogUtil.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1594/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1NlbnNpdGl2ZUxvZ1V0aWwuamF2YQ==) | `0% <0%> (ø)` | |
| [...he/dolphinscheduler/server/utils/RemoveZKNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1594/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1JlbW92ZVpLTm9kZS5qYXZh) | `0% <0%> (ø)` | |
| [...lphinscheduler/server/monitor/AbstractMonitor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1594/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvQWJzdHJhY3RNb25pdG9yLmphdmE=) | `0% <0%> (ø)` | |
| [...dolphinscheduler/server/monitor/ZKMonitorImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1594/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvWktNb25pdG9ySW1wbC5qYXZh) | `0% <0%> (ø)` | |
| [...pache/dolphinscheduler/alert/utils/ExcelUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1594/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FeGNlbFV0aWxzLmphdmE=) | `79.62% <100%> (+1.62%)` | :arrow_up: |
| ... and [21 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1594/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1594?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1594?src=pr&el=footer). Last update [026fdd9...110de68](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1594?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- merged pull request #1594:
Fix format bug
Posted by GitBox <gi...@apache.org>.
Technoboy- merged pull request #1594: Fix format bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1594
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services