You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/04 10:55:15 UTC

[GitHub] [cloudstack] shwstppr opened a new pull request #4650: test: hardware required for changeserviceoffering 

shwstppr opened a new pull request #4650:
URL: https://github.com/apache/cloudstack/pull/4650


   ### Description
   
   With #4491, root disks of VMs will be resized while changing service offering.
   On simulator this would fail and will need actual hypervisor to test.
   Component test test_01_change_service_offering  in test_mm_domain_limits.py has been tagged to require hardware to address this.
   This will skip run for this test on travis.
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4650: test: hardware required for changeserviceoffering

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4650:
URL: https://github.com/apache/cloudstack/pull/4650#issuecomment-773317136


   Looks like you've fixed it as well cc @Pearl1594 @DaanHoogland 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #4650: test: hardware required for changeserviceoffering

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4650:
URL: https://github.com/apache/cloudstack/pull/4650


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4650: test: hardware required for changeserviceoffering

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4650:
URL: https://github.com/apache/cloudstack/pull/4650#issuecomment-773317136


   Looks like you've fixed it as well cc @Pearl1594 @DaanHoogland 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org