[jira] [Commented] (EXTVAL-133) tests in test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage should customize servletContext as part of setup

["Rudy De Busscher (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/EXTVAL-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040188#comment-13040188 ] 

Rudy De Busscher commented on EXTVAL-133:
-----------------------------------------

Verified the test modules on the branch20.  Did the following things
- Copied classes fro trunk to the branch
- Changed POM files so that 2.0 versions of dependencies are used (test20, JSF 2.0, ...)
- Applied patch on this issue
- Running against a MyFacesTest with issues 50 and 53 fixed

-> Everything works except the CustomProjectStageTestCase. Probably because the tweak (as mentioned in the description) isn't in the patch.

> tests in test-modules/core-tests/src/test/java/org/apache/myfaces/extensions/validator/test/core/stage should customize servletContext as part of setup
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: EXTVAL-133
>                 URL: https://issues.apache.org/jira/browse/EXTVAL-133
>             Project: MyFaces Extensions Validator
>          Issue Type: Test
>    Affects Versions: 2.0.5
>            Reporter: Matt Benson
>            Assignee: Rudy De Busscher
>         Attachments: EXTVAL-133.patch.txt
>
>
> these tests work in trunk, but when running them against https://svn.apache.org/repos/asf/myfaces/extensions/validator/branches/branch_for_jsf_2_0, they fail because the DefaultELHelper requests the ProjectStage so that it is cached before the testcase has the chance to add the "javax.faces.PROJECT_STAGE" init parameter.  The attached patch continues to test successfully against trunk _and_ (with the minor tweak of a custom ProjectStageResolver for the CustomProjectStageTestCase) works for JSF 2.0 .

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira