[GitHub] [iceberg] rdblue commented on a diff in pull request #4437: Static Analysis: Supressions we know are false positive

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4437:
URL: https://github.com/apache/iceberg/pull/4437#discussion_r841280773


##########
core/src/main/java/org/apache/iceberg/util/Tasks.java:
##########
@@ -300,49 +301,46 @@ private void tryRunOnFailure(I item, Exception failure) {
 
       for (final I item : items) {
         // submit a task for each item that will either run or abort the task
-        futures.add(service.submit(new Runnable() {
-          @Override
-          public void run() {
-            if (!(stopOnFailure && taskFailed.get())) {
-              // run the task with retries
-              boolean threw = true;
-              try {
-                runTaskWithRetry(task, item);
+        futures.add(service.submit(() -> {
+          if (!(stopOnFailure && taskFailed.get())) {
+            // run the task with retries
+            boolean threw = true;
+            try {
+              runTaskWithRetry(task, item);

Review Comment:
   I don't think that suppressing warnings should change this class at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org