[jira] [Commented] (CALCITE-3738) Missing order by logical plan for insert statement

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016244#comment-17016244 ] 

Julian Hyde commented on CALCITE-3738:
--------------------------------------

It depends how you define sub-query. It is a query that is nested inside a statement. Also, the order that rows are inserted does not matter.

So, I don't think we should fix this.

Arguably we should not allow ORDER BY in an INSERT (or UPDATE or DELETE) statement.

> Missing order by logical plan for insert statement
> --------------------------------------------------
>
>                 Key: CALCITE-3738
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3738
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.19.0
>            Reporter: pengzhiwei
>            Assignee: pengzhiwei
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The following sql statement generates a wrong logical plan which missing the LogicalSort :
> {code:java}
> insert into t select id*10,name from users order by name;{code}
> the plan is :
> {code:java}
> LogicalTableModify(table=[[t]], operation=[INSERT], flattened=[false])
>   LogicalProject(id=[*($0, 10)], name=[$1])
>     LogicalTableScan(table=[[users]])
> {code}
> This issue is introduced by the issue https://issues.apache.org/jira/browse/CALCITE-2978 
> which removes the sort by in sub-query.However the query in insert statement is not a sub-query.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)