You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/07/12 14:47:57 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #6199: NIFI-10219 Remove jna-platform from nifi-bootstrap-utils

exceptionfactory opened a new pull request, #6199:
URL: https://github.com/apache/nifi/pull/6199

   # Summary
   
   [NIFI-10219](https://issues.apache.org/jira/browse/NIFI-10219) Removes the `jna-platform` dependency from `nifi-bootstrap-utils` and removes the private `OSUtils.getWindowsProcessId()` method which depends on reflection and JNA access for Java 8 on Windows.
   
   Removing the `jna-platform` dependency removes support for retrieving spawned Process Identifiers on Windows when running on Java 8, but all references to `OSUtils.getProcessId()` treat the PID as optional. Furthermore, the bootstrap components leverage `ps` and `kill` commands that are not available on Windows, so having the PID available on Windows does not support additional operations. Java 9 and following provide a standard method for retrieving the PID.
   
   Eliminating the direct dependency on `jna-platform` removes the library from `lib/bootstrap` and allows the library to be placed in `lib/properties` as a transitive dependency of `nifi-property-protection-azure`, avoiding runtime class definition issues. This also avoids the need to adjust the `nifi-assembly` configuration to remove the `jna-platform` dependency to a different location, or provide multiple copies.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] jfrazee commented on pull request #6199: NIFI-10219 Remove jna-platform from nifi-bootstrap-utils

Posted by GitBox <gi...@apache.org>.
jfrazee commented on PR #6199:
URL: https://github.com/apache/nifi/pull/6199#issuecomment-1182119822

   Thanks @exceptionfactory. I verified the fix and checked that there were minimal changes in ./lib. I'm running the contrib-check and will merge shortly assuming no issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] jfrazee closed pull request #6199: NIFI-10219 Remove jna-platform from nifi-bootstrap-utils

Posted by GitBox <gi...@apache.org>.
jfrazee closed pull request #6199: NIFI-10219 Remove jna-platform from nifi-bootstrap-utils
URL: https://github.com/apache/nifi/pull/6199


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org