You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Dapeng Sun (JIRA)" <ji...@apache.org> on 2016/06/24 06:25:16 UTC

[jira] [Resolved] (CRYPTO-83) Utils.getRandomDevPath should be private method in OsCryptoRandom

     [ https://issues.apache.org/jira/browse/CRYPTO-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dapeng Sun resolved CRYPTO-83.
------------------------------
    Resolution: Fixed

> Utils.getRandomDevPath should be private method in OsCryptoRandom
> -----------------------------------------------------------------
>
>                 Key: CRYPTO-83
>                 URL: https://issues.apache.org/jira/browse/CRYPTO-83
>             Project: Commons Crypto
>          Issue Type: Bug
>            Reporter: Sebb
>            Assignee: Dapeng Sun
>            Priority: Minor
>
> The method Utils.getRandomDevPath is only used from OsCryptoRandom and should probably be moved there.
> Likewise the default value constant
> COMMONS_CRYPTO_SECURE_RANDOM_DEVICE_FILE_PATH_DEFAULT
> does not really make much sense except to the OsCryptoRandom class.
> Note: property key names do need to be centrally defined to avoid duplication.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)