You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "mikemccand (via GitHub)" <gi...@apache.org> on 2024/10/09 12:07:35 UTC
[PR] Add tooling back on 9.10.x branch to generate int7_hnsw.9.10.zip bwc index [lucene]
mikemccand opened a new pull request, #13879:
URL: https://github.com/apache/lucene/pull/13879
Spinoff from #13867 to add the tooling back onto `branch_9_10` in case we ever need to regenerate the `int7_hnsw.9.10.0.zip` bwc index again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add tooling back on 9.10.x branch to generate int7_hnsw.9.10.zip bwc index [lucene]
Posted by "ChrisHegarty (via GitHub)" <gi...@apache.org>.
ChrisHegarty commented on code in PR #13879:
URL: https://github.com/apache/lucene/pull/13879#discussion_r1793484452
##########
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestGenerateBwcIndices.java:
##########
@@ -82,6 +82,16 @@ public void testCreateSortedIndex() throws IOException {
sortedTest.createBWCIndex();
}
+ public void testCreateInt7HNSWIndices() throws IOException {
Review Comment:
this rename, same as in the other PR, breaks the add back compat script. I wonder if we should just avoid the renames in 9.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add tooling back on 9.10.x branch to generate int7_hnsw.9.10.zip bwc index [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand commented on code in PR #13879:
URL: https://github.com/apache/lucene/pull/13879#discussion_r1795372954
##########
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestGenerateBwcIndices.java:
##########
@@ -82,6 +82,16 @@ public void testCreateSortedIndex() throws IOException {
sortedTest.createBWCIndex();
}
+ public void testCreateInt7HNSWIndices() throws IOException {
Review Comment:
Hmm I think we can just rename `int8_hnsw` -> `int7_hnsw` in `addBackCompatIndexes.py`? But I would do that change on our latest branches (9.12.x, 10.x, 10.0.x) as a separate follow-on PR? This PR is just targetting 9.10.x branch in case we ever need to regen 9.10.x bwc indices again (hope not!).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add tooling back on 9.10.x branch to generate int7_hnsw.9.10.zip bwc index [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13879:
URL: https://github.com/apache/lucene/pull/13879#issuecomment-2436563159
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add tooling back on 9.10.x branch to generate int7_hnsw.9.10.zip bwc index [lucene]
Posted by "ChrisHegarty (via GitHub)" <gi...@apache.org>.
ChrisHegarty commented on code in PR #13879:
URL: https://github.com/apache/lucene/pull/13879#discussion_r1793484452
##########
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestGenerateBwcIndices.java:
##########
@@ -82,6 +82,16 @@ public void testCreateSortedIndex() throws IOException {
sortedTest.createBWCIndex();
}
+ public void testCreateInt7HNSWIndices() throws IOException {
Review Comment:
this rename, same as in the other PR, breaks the add back compat script. I wonder if we should just avoid the renames in 9.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add tooling back on 9.10.x branch to generate int7_hnsw.9.10.zip bwc index [lucene]
Posted by "ChrisHegarty (via GitHub)" <gi...@apache.org>.
ChrisHegarty commented on code in PR #13879:
URL: https://github.com/apache/lucene/pull/13879#discussion_r1793486021
##########
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestGenerateBwcIndices.java:
##########
@@ -82,6 +82,16 @@ public void testCreateSortedIndex() throws IOException {
sortedTest.createBWCIndex();
}
+ public void testCreateInt7HNSWIndices() throws IOException {
Review Comment:
should we add this to the back compat script? And if so then there could be a collision with future versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org