[GitHub] [zookeeper] TisonKun commented on a change in pull request #1023: ZOOKEEPER-3468: Enable BookKeeper checkstyle configuration on zookeeper-jute

[GitBox <gi...@apache.org>]

TisonKun commented on a change in pull request #1023: ZOOKEEPER-3468: Enable BookKeeper checkstyle configuration on zookeeper-jute
URL: https://github.com/apache/zookeeper/pull/1023#discussion_r307127511
 
 

 ##########
 File path: zookeeper-jute/src/main/java/org/apache/jute/BinaryInputArchive.java
 ##########
 @@ -22,108 +22,124 @@
 import java.io.DataInputStream;
 import java.io.IOException;
 import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
 
 /**
  *
 
 Review comment:
   Yes we have. If we remove this placeholder checkstyle would fail on
   
   >[ERROR] /Users/chenzili/IdeaProjects/zookeeper/zookeeper-jute/src/main/java/org/apache/jute/BinaryInputArchive.java:28: Missing a Javadoc comment. [JavadocType]
   
   However, it just checks whether or not there is a javadoc.
   
   If you want to forbid empty javadoc as well, we can enable 
   
   ```
   <module name="JavadocStyle">
     <property name="checkEmptyJavadoc" value="true"/>
   </module>
   ```
   
   But I'm afraid it would be not easy to add proper javadoc in this pass. We can file another JIRA fixing all empty javadoc and enable this property. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services