You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/06 22:27:56 UTC
[GitHub] [incubator-superset] bkyryliuk opened a new pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
bkyryliuk opened a new pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179
### SUMMARY
Simplifies alerting data models and merges validator and observer objects into the alert.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TODO
### TEST PLAN
[] unit tests
[] staging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `4.38%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 61.29% -4.39%
==========================================
Files 828 829 +1
Lines 39167 39206 +39
Branches 3589 3586 -3
==========================================
- Hits 25725 24030 -1695
- Misses 13331 14996 +1665
- Partials 111 180 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.29% <ø> (-0.01%)` | :arrow_down: |
| #python | `60.69% <23.40%> (-0.34%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.03% <0.00%> (-0.43%)` | :arrow_down: |
| ... and [877 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...1cb1039](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `5.40%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.43% 60.02% -5.41%
==========================================
Files 829 393 -436
Lines 39200 24614 -14586
Branches 3693 0 -3693
==========================================
- Hits 25649 14774 -10875
+ Misses 13444 9840 -3604
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.02% <23.40%> (-0.59%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| ... and [442 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [9785667...f59a93d](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `4.84%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 60.83% -4.85%
==========================================
Files 828 829 +1
Lines 39167 39206 +39
Branches 3589 3586 -3
==========================================
- Hits 25725 23852 -1873
- Misses 13331 15174 +1843
- Partials 111 180 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.29% <ø> (-0.01%)` | :arrow_down: |
| #python | `59.97% <23.40%> (-1.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| ... and [888 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...4723123](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.43% 65.41% -0.02%
==========================================
Files 829 829
Lines 39200 39207 +7
Branches 3693 3694 +1
==========================================
Hits 25649 25649
- Misses 13444 13448 +4
- Partials 107 110 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.88% <ø> (+0.01%)` | :arrow_up: |
| #javascript | `62.30% <ø> (-0.03%)` | :arrow_down: |
| #python | `60.70% <23.40%> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | | |
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UaW1lU2VyaWVzQ29sdW1uQ29udHJvbC5qc3g=) | | |
| ... and [875 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [9785667...c8dbecd](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 65.41% -0.27%
==========================================
Files 828 829 +1
Lines 39167 39209 +42
Branches 3589 3586 -3
==========================================
- Hits 25725 25650 -75
- Misses 13331 13448 +117
Partials 111 111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.85% <ø> (-0.22%)` | :arrow_down: |
| #javascript | `62.29% <ø> (-0.01%)` | :arrow_down: |
| #python | `60.69% <23.40%> (-0.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.03% <0.00%> (-0.43%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.20% <0.00%> (-0.06%)` | :arrow_down: |
| ... and [876 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...1cb1039](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `4.40%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 61.27% -4.41%
==========================================
Files 828 829 +1
Lines 39167 39206 +39
Branches 3589 3586 -3
==========================================
- Hits 25725 24025 -1700
- Misses 13331 15001 +1670
- Partials 111 180 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.29% <ø> (-0.01%)` | :arrow_down: |
| #python | `60.67% <23.40%> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [879 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...4723123](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `4.97%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 60.70% -4.98%
==========================================
Files 828 393 -435
Lines 39167 24619 -14548
Branches 3589 0 -3589
==========================================
- Hits 25725 14946 -10779
+ Misses 13331 9673 -3658
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.70% <23.40%> (-0.32%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [...set/superset-frontend/src/components/ChartIcon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9DaGFydEljb24udHN4) | | |
| [...tend/src/dashboard/components/DashboardBuilder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvRGFzaGJvYXJkQnVpbGRlci5qc3g=) | | |
| ... and [435 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...c836428](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `0.33%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 65.34% -0.34%
==========================================
Files 828 829 +1
Lines 39167 39212 +45
Branches 3589 3589
==========================================
- Hits 25725 25624 -101
- Misses 13331 13476 +145
- Partials 111 112 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.20% <ø> (-0.87%)` | :arrow_down: |
| #javascript | `62.30% <ø> (ø)` | |
| #python | `60.70% <23.40%> (-0.32%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL3JlZHVjZXJzL2dldEluaXRpYWxTdGF0ZS5qcw==) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvU3FsRWRpdG9yTGVmdEJhci5qc3g=) | `44.00% <0.00%> (-12.00%)` | :arrow_down: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvdmlzdWFsaXphdGlvbnMvRmlsdGVyQm94L0ZpbHRlckJveC5qc3g=) | `56.17% <0.00%> (-9.88%)` | :arrow_down: |
| ... and [12 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...c836428](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `4.97%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 60.70% -4.98%
==========================================
Files 828 393 -435
Lines 39167 24619 -14548
Branches 3589 0 -3589
==========================================
- Hits 25725 14946 -10779
+ Misses 13331 9673 -3658
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.70% <23.40%> (-0.32%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [...rontend/src/explore/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC50c3g=) | | |
| [.../dashboard/util/charts/getEffectiveExtraFilters.ts](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvY2hhcnRzL2dldEVmZmVjdGl2ZUV4dHJhRmlsdGVycy50cw==) | | |
| ... and [435 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...c836428](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `5.76%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 59.91% -5.77%
==========================================
Files 828 393 -435
Lines 39167 24598 -14569
Branches 3589 0 -3589
==========================================
- Hits 25725 14738 -10987
+ Misses 13331 9860 -3471
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `59.91% <23.40%> (-1.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| ... and [454 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...4723123](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `5.70%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 59.97% -5.71%
==========================================
Files 828 393 -435
Lines 39167 24600 -14567
Branches 3589 0 -3589
==========================================
- Hits 25725 14753 -10972
+ Misses 13331 9847 -3484
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `59.97% <23.40%> (-1.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| ... and [452 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...4723123](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `3.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.43% 62.33% -3.10%
==========================================
Files 829 437 -392
Lines 39200 14628 -24572
Branches 3693 3693
==========================================
- Hits 25649 9118 -16531
+ Misses 13444 5329 -8115
- Partials 107 181 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.33% <ø> (ø)` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [550 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [9785667...62dbb84](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 65.42% -0.26%
==========================================
Files 828 829 +1
Lines 39167 39212 +45
Branches 3589 3589
==========================================
- Hits 25725 25654 -71
- Misses 13331 13447 +116
Partials 111 111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.84% <ø> (-0.22%)` | :arrow_down: |
| #javascript | `62.30% <ø> (ø)` | |
| #python | `60.70% <23.40%> (-0.32%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvdmlzdWFsaXphdGlvbnMvRmlsdGVyQm94L0ZpbHRlckJveC5qc3g=) | `56.17% <0.00%> (-9.88%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvZ3JpZENvbXBvbmVudHMvQ2hhcnQuanN4) | `83.67% <0.00%> (-2.05%)` | :arrow_down: |
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2FjdGlvbnMvZGFzaGJvYXJkU3RhdGUuanM=) | `50.32% <0.00%> (-1.31%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...c836428](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk merged pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
bkyryliuk merged pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-706394072
> LGTM, left a couple of optional comments
thanks for the review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `5.65%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 60.02% -5.66%
==========================================
Files 828 393 -435
Lines 39167 24589 -14578
Branches 3589 0 -3589
==========================================
- Hits 25725 14760 -10965
+ Misses 13331 9829 -3502
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.02% <23.40%> (-1.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| ... and [454 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...1cb1039](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `9.84%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 55.83% -9.85%
==========================================
Files 828 402 -426
Lines 39167 13338 -25829
Branches 3589 3389 -200
==========================================
- Hits 25725 7447 -18278
+ Misses 13331 5704 -7627
- Partials 111 187 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.83% <ø> (-0.24%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvZG5kLXJlb3JkZXIuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvZ2V0RW1wdHlMYXlvdXQuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/dashboard/util/getLayoutComponentFromChartId.js](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvZ2V0TGF5b3V0Q29tcG9uZW50RnJvbUNoYXJ0SWQuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvcmVzaXphYmxlL1Jlc2l6YWJsZUhhbmRsZS5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvZ2V0RmlsdGVyU2NvcGVGcm9tTm9kZXNUcmVlLmpz) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvdXRpbHMvZ2V0Q2xpZW50RXJyb3JPYmplY3QudHM=) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvRmlsdGVySW5kaWNhdG9yR3JvdXAuanN4) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL2NvbnRyb2xzL3dpdGhWZXJpZmljYXRpb24uanN4) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvZ3JpZENvbXBvbmVudHMvSGVhZGVyLmpzeA==) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rset-frontend/src/profile/components/Favorites.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvcHJvZmlsZS9jb21wb25lbnRzL0Zhdm9yaXRlcy50c3g=) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [640 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...c836428](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `4.99%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 60.68% -5.00%
==========================================
Files 828 393 -435
Lines 39167 24600 -14567
Branches 3589 0 -3589
==========================================
- Hits 25725 14929 -10796
+ Misses 13331 9671 -3660
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.68% <23.40%> (-0.35%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.50% <0.00%> (-2.50%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.38% <0.00%> (-0.53%)` | :arrow_down: |
| ... and [443 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...1cb1039](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `4.55%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.43% 60.87% -4.56%
==========================================
Files 829 829
Lines 39200 39204 +4
Branches 3693 3694 +1
==========================================
- Hits 25649 23864 -1785
- Misses 13444 15159 +1715
- Partials 107 181 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.30% <ø> (-0.03%)` | :arrow_down: |
| #python | `60.02% <23.40%> (-0.59%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| ... and [878 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [9785667...c8dbecd](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `4.24%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.43% 61.18% -4.25%
==========================================
Files 829 829
Lines 39200 39204 +4
Branches 3693 3694 +1
==========================================
- Hits 25649 23986 -1663
- Misses 13444 15037 +1593
- Partials 107 181 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.30% <ø> (-0.03%)` | :arrow_down: |
| #python | `60.51% <23.40%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| ... and [879 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [9785667...c8dbecd](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `4.38%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 61.29% -4.39%
==========================================
Files 828 829 +1
Lines 39167 39206 +39
Branches 3589 3586 -3
==========================================
- Hits 25725 24031 -1694
- Misses 13331 14995 +1664
- Partials 111 180 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.29% <ø> (-0.01%)` | :arrow_down: |
| #python | `60.69% <23.40%> (-0.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.03% <0.00%> (-0.43%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.20% <0.00%> (-0.06%)` | :arrow_down: |
| ... and [876 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...1cb1039](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `5.78%`.
> The diff coverage is `23.74%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.43% 59.64% -5.79%
==========================================
Files 829 393 -436
Lines 39200 24601 -14599
Branches 3693 0 -3693
==========================================
- Hits 25649 14674 -10975
+ Misses 13444 9927 -3517
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `59.64% <23.74%> (-0.96%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| ... and [461 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [9785667...a72103a](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#discussion_r502662154
##########
File path: superset/views/alerts.py
##########
@@ -248,5 +170,12 @@ def pre_add(self, item: "AlertModelView") -> None:
if not croniter.is_valid(item.crontab):
raise SupersetException("Invalid crontab format")
+ item.validator_type = item.validator_type.lower()
+ check_validator(item.validator_type, item.validator_config)
+
+ def pre_update(self, item: "AlertModelView") -> None:
+ item.validator_type = item.validator_type.lower()
+ check_validator(item.validator_type, item.validator_config)
Review comment:
this code will be removed in a couple of weeks as I understand, will keep it this way for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `5.40%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.43% 60.02% -5.41%
==========================================
Files 829 393 -436
Lines 39200 24603 -14597
Branches 3693 0 -3693
==========================================
- Hits 25649 14769 -10880
+ Misses 13444 9834 -3610
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.02% <23.40%> (-0.58%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| ... and [448 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [9785667...f59a93d](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `0.33%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 65.34% -0.34%
==========================================
Files 828 829 +1
Lines 39167 39209 +42
Branches 3589 3586 -3
==========================================
- Hits 25725 25620 -105
- Misses 13331 13477 +146
- Partials 111 112 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.20% <ø> (-0.86%)` | :arrow_down: |
| #javascript | `62.29% <ø> (-0.01%)` | :arrow_down: |
| #python | `60.69% <23.40%> (-0.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.03% <0.00%> (-0.43%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.20% <0.00%> (-0.06%)` | :arrow_down: |
| ... and [876 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...1cb1039](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `4.55%`.
> The diff coverage is `23.74%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.43% 60.87% -4.56%
==========================================
Files 829 829
Lines 39200 39191 -9
Branches 3693 3694 +1
==========================================
- Hits 25649 23859 -1790
- Misses 13444 15151 +1707
- Partials 107 181 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.30% <ø> (-0.03%)` | :arrow_down: |
| #python | `60.03% <23.74%> (-0.58%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| ... and [884 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [9785667...a72103a](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `4.98%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 60.69% -4.99%
==========================================
Files 828 393 -435
Lines 39167 24600 -14567
Branches 3589 0 -3589
==========================================
- Hits 25725 14931 -10794
+ Misses 13331 9669 -3662
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.69% <23.40%> (-0.34%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.03% <0.00%> (-0.43%)` | :arrow_down: |
| ... and [441 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...1cb1039](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `6.03%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 59.64% -6.04%
==========================================
Files 828 393 -435
Lines 39167 24589 -14578
Branches 3589 0 -3589
==========================================
- Hits 25725 14665 -11060
+ Misses 13331 9924 -3407
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `59.64% <23.40%> (-1.39%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| ... and [466 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...1cb1039](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `4.79%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.43% 60.63% -4.80%
==========================================
Files 829 829
Lines 39200 39193 -7
Branches 3693 3694 +1
==========================================
- Hits 25649 23764 -1885
- Misses 13444 15248 +1804
- Partials 107 181 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.30% <ø> (-0.03%)` | :arrow_down: |
| #python | `59.64% <23.40%> (-0.97%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| ... and [897 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [9785667...c8dbecd](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.43% 65.34% -0.09%
==========================================
Files 829 829
Lines 39200 39207 +7
Branches 3693 3694 +1
==========================================
- Hits 25649 25619 -30
- Misses 13444 13477 +33
- Partials 107 111 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.24% <ø> (-0.63%)` | :arrow_down: |
| #javascript | `62.30% <ø> (-0.03%)` | :arrow_down: |
| #python | `60.70% <23.40%> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [...frontend/src/SqlLab/components/QueryStateLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U3RhdGVMYWJlbC5qc3g=) | | |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | | |
| ... and [875 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [9785667...c8dbecd](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `4.97%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 60.70% -4.98%
==========================================
Files 828 393 -435
Lines 39167 24619 -14548
Branches 3589 0 -3589
==========================================
- Hits 25725 14946 -10779
+ Misses 13331 9673 -3658
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.70% <23.40%> (-0.32%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [...ator-superset/superset-frontend/src/views/menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvdmlld3MvbWVudS50c3g=) | | |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvdmlld3MvQ1JVRC9kYXRhL2RhdGFzZXQvRGF0YXNldExpc3QudHN4) | | |
| ... and [435 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...c836428](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#discussion_r502591556
##########
File path: superset/migrations/versions/af30ca79208f_collapse_alerting_models_into_a_single_.py
##########
@@ -0,0 +1,299 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Collapse alerting models into a single one
+
+Revision ID: af30ca79208f
+Revises: b56500de1855
+Create Date: 2020-10-05 18:10:52.272047
+
+"""
+
+import sqlalchemy as sa
+from alembic import op
+from sqlalchemy.dialects.sqlite.base import SQLiteDialect
+from sqlalchemy.ext.declarative import declarative_base, declared_attr
+from sqlalchemy.orm import backref, relationship, RelationshipProperty
+
+from superset import db
+from superset.utils.core import generic_find_fk_constraint_name
+
+revision = "af30ca79208f"
+down_revision = "b56500de1855"
+
+
+Base = declarative_base()
+
+
+class Alert(Base):
+ __tablename__ = "alerts"
+ id = sa.Column(sa.Integer, primary_key=True)
+ sql = sa.Column(sa.Text, nullable=False)
+ validator_type = sa.Column(sa.String(100), nullable=False)
+ validator_config = sa.Column(sa.Text)
+ database_id = sa.Column(sa.Integer)
+
+
+class SQLObserver(Base):
+ __tablename__ = "sql_observers"
+
+ id = sa.Column(sa.Integer, primary_key=True)
+ sql = sa.Column(sa.Text, nullable=False)
+ database_id = sa.Column(sa.Integer)
+
+ @declared_attr
+ def alert_id(self) -> int:
+ return sa.Column(sa.Integer, sa.ForeignKey("alerts.id"), nullable=False)
+
+ @declared_attr
+ def alert(self) -> RelationshipProperty:
+ return relationship(
+ "Alert",
+ foreign_keys=[self.alert_id],
+ backref=backref("sql_observer", cascade="all, delete-orphan"),
+ )
+
+
+class Validator(Base):
+ __tablename__ = "alert_validators"
+
+ id = sa.Column(sa.Integer, primary_key=True)
+ validator_type = sa.Column(sa.String(100), nullable=False)
+ config = sa.Column(sa.Text)
+
+ @declared_attr
+ def alert_id(self) -> int:
+ return sa.Column(sa.Integer, sa.ForeignKey("alerts.id"), nullable=False)
+
+ @declared_attr
+ def alert(self) -> RelationshipProperty:
+ return relationship(
+ "Alert",
+ foreign_keys=[self.alert_id],
+ backref=backref("validators", cascade="all, delete-orphan"),
+ )
+
+
+def upgrade():
+ bind = op.get_bind()
+ insp = sa.engine.reflection.Inspector.from_engine(bind)
+
+ if isinstance(bind.dialect, SQLiteDialect):
+ op.add_column(
+ "alerts",
+ sa.Column("validator_config", sa.Text(), server_default="", nullable=True),
+ )
+ op.add_column(
+ "alerts",
+ sa.Column("database_id", sa.Integer(), server_default="0", nullable=False),
+ )
+ op.add_column(
+ "alerts", sa.Column("sql", sa.Text(), server_default="", nullable=False)
+ )
+ op.add_column(
+ "alerts",
+ sa.Column(
+ "validator_type",
+ sa.String(length=100),
+ server_default="",
+ nullable=False,
+ ),
+ )
+ else: # mysql does not support server_default for text fields
+ op.add_column(
+ "alerts",
+ sa.Column("validator_config", sa.Text(), default="", nullable=True),
+ )
+ op.add_column(
+ "alerts", sa.Column("database_id", sa.Integer(), default=0, nullable=False),
+ )
+ op.add_column("alerts", sa.Column("sql", sa.Text(), default="", nullable=False))
+ op.add_column(
+ "alerts",
+ sa.Column(
+ "validator_type", sa.String(length=100), default="", nullable=False
+ ),
+ )
+ # Migrate data
+ session = db.Session(bind=bind)
+ alerts = session.query(Alert).all()
+ for a in alerts:
+ if a.sql_observer:
+ a.sql = a.sql_observer[0].sql
+ a.database_id = a.sql_observer[0].database_id
+ if a.validators:
+ a.validator_type = a.validators[0].validator_type
+ a.validator_config = a.validators[0].config
+ session.commit()
+
+ # op.alter_column('alerts', 'database_id', server_default=None)
Review comment:
remove?
##########
File path: superset/views/alerts.py
##########
@@ -248,5 +170,12 @@ def pre_add(self, item: "AlertModelView") -> None:
if not croniter.is_valid(item.crontab):
raise SupersetException("Invalid crontab format")
+ item.validator_type = item.validator_type.lower()
+ check_validator(item.validator_type, item.validator_config)
+
+ def pre_update(self, item: "AlertModelView") -> None:
+ item.validator_type = item.validator_type.lower()
+ check_validator(item.validator_type, item.validator_config)
Review comment:
It brings a better used experience to use Flask-WTF validators instead: https://wtforms.readthedocs.io/en/2.3.x/validators/#module-wtforms.validators. This way the user get's alerted about a validation fail while still on the form and not after submitting
##########
File path: tests/alerts_tests.py
##########
@@ -165,41 +148,38 @@ def test_alert_observer(setup_database):
WHERE first = 1
""",
)
- observe(alert8.id, dbsession)
- assert alert8.sql_observer[0].observations[-1].value == 1.0
- assert alert8.sql_observer[0].observations[-1].error_msg is None
+ observe(alert8.id, db_session)
+ assert alert8.observations[-1].value == 1.0
+ assert alert8.observations[-1].error_msg is None
# Test jinja
- alert9 = create_alert(dbsession, "SELECT {{ 2 }}")
- observe(alert9.id, dbsession)
- assert alert9.sql_observer[0].observations[-1].value == 2.0
- assert alert9.sql_observer[0].observations[-1].error_msg is None
+ alert9 = create_alert(db_session, "SELECT {{ 2 }}")
+ observe(alert9.id, db_session)
+ assert alert9.observations[-1].value == 2.0
+ assert alert9.observations[-1].error_msg is None
@patch("superset.tasks.schedules.deliver_alert")
def test_evaluate_alert(mock_deliver_alert, setup_database):
- dbsession = setup_database
+ db_session = setup_database
Review comment:
sort of related, but looking at `setup_database` does it make sense at the cleanup to `DROP TABLE test_table` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `3.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.43% 62.33% -3.10%
==========================================
Files 829 437 -392
Lines 39200 14628 -24572
Branches 3693 3693
==========================================
- Hits 25649 9118 -16531
+ Misses 13444 5329 -8115
- Partials 107 181 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.33% <ø> (ø)` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [550 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [9785667...62dbb84](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `4.91%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.43% 60.51% -4.92%
==========================================
Files 829 393 -436
Lines 39200 24614 -14586
Branches 3693 0 -3693
==========================================
- Hits 25649 14896 -10753
+ Misses 13444 9718 -3726
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.51% <23.40%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| ... and [443 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [9785667...f59a93d](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `6.65%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.43% 58.77% -6.66%
==========================================
Files 829 795 -34
Lines 39200 37952 -1248
Branches 3693 3431 -262
==========================================
- Hits 25649 22308 -3341
- Misses 13444 15451 +2007
- Partials 107 193 +86
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.23% <ø> (-0.64%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `60.70% <23.40%> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | | |
| ... and [841 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [9785667...f59a93d](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `5.17%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 60.50% -5.18%
==========================================
Files 828 393 -435
Lines 39167 24600 -14567
Branches 3589 0 -3589
==========================================
- Hits 25725 14884 -10841
+ Misses 13331 9716 -3615
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.50% <23.40%> (-0.53%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| ... and [448 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...1cb1039](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `5.78%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.43% 59.64% -5.79%
==========================================
Files 829 393 -436
Lines 39200 24603 -14597
Branches 3693 0 -3693
==========================================
- Hits 25649 14674 -10975
+ Misses 13444 9929 -3515
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `59.64% <23.40%> (-0.97%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| ... and [461 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [9785667...f59a93d](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `4.97%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 60.70% -4.98%
==========================================
Files 828 393 -435
Lines 39167 24619 -14548
Branches 3589 0 -3589
==========================================
- Hits 25725 14946 -10779
+ Misses 13331 9673 -3658
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.70% <23.40%> (-0.32%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [...rontend/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3JlZHVjZXJzL2Rhc2hib2FyZEZpbHRlcnMuanM=) | | |
| [.../superset-frontend/src/common/components/Modal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tbW9uL2NvbXBvbmVudHMvTW9kYWwudHN4) | | |
| ... and [435 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...c836428](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#discussion_r502661870
##########
File path: tests/alerts_tests.py
##########
@@ -165,41 +148,38 @@ def test_alert_observer(setup_database):
WHERE first = 1
""",
)
- observe(alert8.id, dbsession)
- assert alert8.sql_observer[0].observations[-1].value == 1.0
- assert alert8.sql_observer[0].observations[-1].error_msg is None
+ observe(alert8.id, db_session)
+ assert alert8.observations[-1].value == 1.0
+ assert alert8.observations[-1].error_msg is None
# Test jinja
- alert9 = create_alert(dbsession, "SELECT {{ 2 }}")
- observe(alert9.id, dbsession)
- assert alert9.sql_observer[0].observations[-1].value == 2.0
- assert alert9.sql_observer[0].observations[-1].error_msg is None
+ alert9 = create_alert(db_session, "SELECT {{ 2 }}")
+ observe(alert9.id, db_session)
+ assert alert9.observations[-1].value == 2.0
+ assert alert9.observations[-1].error_msg is None
@patch("superset.tasks.schedules.deliver_alert")
def test_evaluate_alert(mock_deliver_alert, setup_database):
- dbsession = setup_database
+ db_session = setup_database
Review comment:
yes !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@152315d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
=========================================
Coverage ? 60.13%
=========================================
Files ? 392
Lines ? 24449
Branches ? 0
=========================================
Hits ? 14702
Misses ? 9747
Partials ? 0
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.13% <45.83%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.08% <ø> (ø)` | |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `79.59% <25.00%> (ø)` | |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (ø)` | |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [152315d...983f9e5](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `6.42%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.43% 59.00% -6.43%
==========================================
Files 829 795 -34
Lines 39200 37952 -1248
Branches 3693 3431 -262
==========================================
- Hits 25649 22394 -3255
- Misses 13444 15370 +1926
- Partials 107 188 +81
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.87% <ø> (+0.01%)` | :arrow_up: |
| #javascript | `?` | |
| #python | `60.70% <23.40%> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [...rset-frontend/src/explore/controlPanels/DeckArc.js](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrQXJjLmpz) | | |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | | |
| ... and [841 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [9785667...f59a93d](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `4.25%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.43% 61.17% -4.26%
==========================================
Files 829 829
Lines 39200 39204 +4
Branches 3693 3694 +1
==========================================
- Hits 25649 23985 -1664
- Misses 13444 15038 +1594
- Partials 107 181 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.30% <ø> (-0.03%)` | :arrow_down: |
| #python | `60.51% <23.40%> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| ... and [879 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [9785667...c8dbecd](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7c60939429b403090c252478b68e598fd37c0d51?el=desc) will **decrease** coverage by `4.69%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.68% 60.98% -4.70%
==========================================
Files 828 829 +1
Lines 39167 39209 +42
Branches 3589 3589
==========================================
- Hits 25725 23911 -1814
- Misses 13331 15118 +1787
- Partials 111 180 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.30% <ø> (ø)` | |
| #python | `60.20% <23.40%> (-0.83%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [...ator-superset/superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tor-superset/superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r-superset/superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [185 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [7c60939...c836428](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> Merging [#11179](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `5.78%`.
> The diff coverage is `23.40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
==========================================
- Coverage 65.43% 59.64% -5.79%
==========================================
Files 829 393 -436
Lines 39200 24603 -14597
Branches 3693 0 -3693
==========================================
- Hits 25649 14674 -10975
+ Misses 13444 9929 -3515
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `59.64% <23.40%> (-0.97%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.00% <ø> (+0.62%)` | :arrow_up: |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <33.33%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (-0.85%)` | :arrow_down: |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (-0.52%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| ... and [461 more](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [9785667...c8dbecd](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11179: chore: simplify alerting data model to leverage a single class [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11179:
URL: https://github.com/apache/incubator-superset/pull/11179#issuecomment-704590181
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@152315d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11179 +/- ##
=========================================
Coverage ? 60.13%
=========================================
Files ? 392
Lines ? 24449
Branches ? 0
=========================================
Hits ? 14702
Misses ? 9747
Partials ? 0
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.13% <45.83%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.08% <ø> (ø)` | |
| [...a79208f\_collapse\_alerting\_models\_into\_a\_single\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZjMwY2E3OTIwOGZfY29sbGFwc2VfYWxlcnRpbmdfbW9kZWxzX2ludG9fYV9zaW5nbGVfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `79.59% <25.00%> (ø)` | |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <87.50%> (ø)` | |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11179/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.36% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=footer). Last update [152315d...983f9e5](https://codecov.io/gh/apache/incubator-superset/pull/11179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org