Re: [SUBMIT] mimemail task

[Erik Hatcher <er...@earthlink.net>]

Whats the status of the <mimemail> task?

Is it committable in its current state or are the changes that Stefan
proposed needed before it can be committed?  Anyone working on these
changes?   I could make the changes needed for the FileSet enhancement if
that is all that is holding up it being committed.   Is a zipfileset or
tarfileset really needed?   Wouldn't it be acceptable to zip or tar files
prior to the executation of the mimemail task?

I just successfully added the MimeMail class to my local installation and
re-built the optional.jar, etc.   It requires the mail.jar and
activation.jar as specified below, which also means that the bootstrap.bat
(and probably others, although I only modified bootstrap.bat on my system)
needs modification to have these jars listed similarly to the junit.jar.
[Or is this modification not really needed and I'm missing some piece in how
optional tasks that depend on other .jars get recognized?]

This task works just fine for what I need.

Thanks,
    Erik "learning more and more about the internals of Ant by the minute!"
Hatcher


----- Original Message -----
From: "Stefan Bodewig" <bo...@apache.org>
To: <an...@jakarta.apache.org>
Sent: Thursday, May 03, 2001 12:58 AM
Subject: Re: [SUBMIT] mimemail task


> Steve Loughran <st...@iseran.com> wrote:
>
> > From: "Stefan Bodewig" <bo...@apache.org>
>
> >> This means, it uses JavaMail instead of org.apache.tools.mail, yes?
> >
> > yes indeed. So while it does more, its requirements are higher.
>
> Hmm, random thought alarm: Make <mail> a facade that uses JavaMail if
> present and falls back to a non MIME version based on Jason's simple
> mail package that ships with Ant.
>
> >> Any reason you need the complete J2EE stuff instead of JavaMail and
> >> Java Activation Framework separately?
> >
> > nope. I didnt know they came in separate jars. If someone sends me
> > the pointers I'll make the build of the file dependent on them and
> > do a doc page to go with it.
>
> JavaMail: <http://java.sun.com/products/javamail/index.html>
>
> Java Activation Framework:
> <http://java.sun.com/products/javabeans/glasgow/jaf.html>
>
> > Also we need to consider whether the file selection process (comma
> > separated list) is adequate.
>
> I'd always prefer something using nested elements over (arbitrarily)
> seperated lists in attributes.
>
> > I'd rather a proper fileset list, maybe with manual mime type
> > override.
>
> This could be a fileset with some additional features, like
> <zipfileset> or <tarfileset>.
>
> Stefan

Re: [SUBMIT] mimemail task

[Steve Loughran <st...@iseran.com>]

----- Original Message -----
From: "Erik Hatcher" <er...@earthlink.net>
To: <an...@jakarta.apache.org>
Sent: Tuesday, June 05, 2001 9:30 PM
Subject: Re: [SUBMIT] mimemail task


> Whats the status of the <mimemail> task?
>
> Is it committable in its current state or are the changes that Stefan
> proposed needed before it can be committed?  Anyone working on these
> changes?   I could make the changes needed for the FileSet enhancement if
> that is all that is holding up it being committed.   Is a zipfileset or
> tarfileset really needed?   Wouldn't it be acceptable to zip or tar files
> prior to the executation of the mimemail task?

I believe a simple fileset is all that is needed, plus build.xml changed to
only buld the file if the appropriate dependencies are found.

I havent done the fileset; didnt know how to at the time. I do now but am
very busy and this task is not a priority. Paulo Gaspar
(paulo.gaspar@krankikom.de) said he was going to have a look at it a week or
two back, the plan being to merge his mail task with mimemail. We should
check what progress he's made.

>
> I just successfully added the MimeMail class to my local installation and
> re-built the optional.jar, etc.   It requires the mail.jar and
> activation.jar as specified below, which also means that the bootstrap.bat
> (and probably others, although I only modified bootstrap.bat on my system)
> needs modification to have these jars listed similarly to the junit.jar.
> [Or is this modification not really needed and I'm missing some piece in
how
> optional tasks that depend on other .jars get recognized?]

The practice for optional jars is their need is mentioned in the task doc
(with URLs) and the build file only builds that file if the optional jars
are found.

One other item to consider is whether there were any unit tests one could
do. I dont want to get into testing email transport itself, but we could
build tests for validating the to and from fields, and for validating the
attachment fileset. If the to=="" validation is done in execute() after
building up the file list, then we could check for the attachment code
working, relying on the destination check to prevent us from sending email.


-steve