You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Jeff Trawick <tr...@gmail.com> on 2013/11/01 15:05:55 UTC
Which of y'all are working on un-APR-izing gen_test_char, and how
will the rest of us know if it is stalled and needs help?
TIA!
--
Born in Roswell... married an alien...
http://emptyhammock.com/
Re: Which of y'all are working on un-APR-izing gen_test_char, and
how will the rest of us know if it is stalled and needs help?
Posted by Gregg Smith <gl...@gknw.net>.
On 11/5/2013 1:51 PM, Graham Leggett wrote:
> On 05 Nov 2013, at 11:04 PM, Jeff Trawick<tr...@gmail.com> wrote:
>
>> TIA! (ping)
>>
>> If nobody in the gen_test_char-with-traditional-Windows-build sub-thread knows what I'm talking about, please let me know. Maybe I am confused about the planned work.
> (Am on holiday and travelling, so have limited time, but this was reasonably straightforward)
>
> This patch removes the APR specific stuff (and therefore the chicken-and-egg problem) and Works for Me(™) on MacOSX 10.8. Is this good enough to work on Windows and other platforms (Linux, etc)?
This works for me, tested on VC9 & 11
Thanks
Re: Which of y'all are working on un-APR-izing gen_test_char, and how
will the rest of us know if it is stalled and needs help?
Posted by Jeff Trawick <tr...@gmail.com>.
On Thu, Nov 7, 2013 at 12:27 AM, William A. Rowe Jr. <wr...@rowe-clan.net>wrote:
> On Wed, 06 Nov 2013 02:20:00 +0100
> Guenter Knauf <fu...@apache.org> wrote:
>
> > Hi,
> > On 05.11.2013 22:51, Graham Leggett wrote:
> > > On 05 Nov 2013, at 11:04 PM, Jeff Trawick <tr...@gmail.com> wrote:
> > >
> > >> TIA! (ping)
> > >>
> > >> If nobody in the gen_test_char-with-traditional-Windows-build
> > >> sub-thread knows what I'm talking about, please let me know.
> > >> Maybe I am confusedabout the planned work.
> > >
> > > (Am on holiday and travelling, so have limited time, but this was
> > > reasonably straightforward)
> > >
> > > This patch removes the APR specific stuff (and therefore the
> > > chicken-and-egg problem) and Works for Me(™) on MacOSX 10.8. Is
> > > this good enough to work on Windows and other platforms (Linux,
> > > etc)?
> > I would prefer to keep the unsigned char casts ...
>
> If the iterator is an unsigned int the promotion should be identical in
> behavior according to K&R v2, the oldest reference I can find.
>
Graham's patch is now in trunk and 1.5.x. I guess that's what Gregg
tested. It works for me on Linux and with the cmake-based build on Windows.
--
Born in Roswell... married an alien...
http://emptyhammock.com/
Re: Which of y'all are working on un-APR-izing gen_test_char, and
how will the rest of us know if it is stalled and needs help?
Posted by "William A. Rowe Jr." <wr...@rowe-clan.net>.
On Wed, 06 Nov 2013 02:20:00 +0100
Guenter Knauf <fu...@apache.org> wrote:
> Hi,
> On 05.11.2013 22:51, Graham Leggett wrote:
> > On 05 Nov 2013, at 11:04 PM, Jeff Trawick <tr...@gmail.com> wrote:
> >
> >> TIA! (ping)
> >>
> >> If nobody in the gen_test_char-with-traditional-Windows-build
> >> sub-thread knows what I'm talking about, please let me know.
> >> Maybe I am confusedabout the planned work.
> >
> > (Am on holiday and travelling, so have limited time, but this was
> > reasonably straightforward)
> >
> > This patch removes the APR specific stuff (and therefore the
> > chicken-and-egg problem) and Works for Me(™) on MacOSX 10.8. Is
> > this good enough to work on Windows and other platforms (Linux,
> > etc)?
> I would prefer to keep the unsigned char casts ...
If the iterator is an unsigned int the promotion should be identical in
behavior according to K&R v2, the oldest reference I can find.
Re: Which of y'all are working on un-APR-izing gen_test_char, and
how will the rest of us know if it is stalled and needs help?
Posted by Guenter Knauf <fu...@apache.org>.
Hi,
On 05.11.2013 22:51, Graham Leggett wrote:
> On 05 Nov 2013, at 11:04 PM, Jeff Trawick <tr...@gmail.com> wrote:
>
>> TIA! (ping)
>>
>> If nobody in the gen_test_char-with-traditional-Windows-build sub-thread knows what I'm talking about, please let me know. Maybe I am confusedabout the planned work.
>
> (Am on holiday and travelling, so have limited time, but this was reasonably straightforward)
>
> This patch removes the APR specific stuff (and therefore the chicken-and-egg problem) and Works for Me(™) on MacOSX 10.8. Is this good enough to work on Windows and other platforms (Linux, etc)?
I would prefer to keep the unsigned char casts ...
Gün.
Re: Which of y'all are working on un-APR-izing gen_test_char, and how will the rest of us know if it is stalled and needs help?
Posted by Graham Leggett <mi...@sharp.fm>.
On 05 Nov 2013, at 11:04 PM, Jeff Trawick <tr...@gmail.com> wrote:
> TIA! (ping)
>
> If nobody in the gen_test_char-with-traditional-Windows-build sub-thread knows what I'm talking about, please let me know. Maybe I am confused about the planned work.
(Am on holiday and travelling, so have limited time, but this was reasonably straightforward)
This patch removes the APR specific stuff (and therefore the chicken-and-egg problem) and Works for Me(™) on MacOSX 10.8. Is this good enough to work on Windows and other platforms (Linux, etc)?
Index: tools/gen_test_char.c
===================================================================
--- tools/gen_test_char.c (revision 1536348)
+++ tools/gen_test_char.c (working copy)
@@ -14,33 +14,14 @@
* limitations under the License.
*/
-#ifdef CROSS_COMPILE
-
-#define apr_isalnum(c) (isalnum(((unsigned char)(c))))
-#define apr_isalpha(c) (isalpha(((unsigned char)(c))))
-#define apr_iscntrl(c) (iscntrl(((unsigned char)(c))))
-#define apr_isprint(c) (isprint(((unsigned char)(c))))
-#include <ctype.h>
-#define APR_HAVE_STDIO_H 1
-#define APR_HAVE_STRING_H 1
-
-#else
-
-#include "apr.h"
-#include "apr_lib.h"
-
-#endif
-
#if defined(WIN32) || defined(OS2)
#define NEED_ENHANCED_ESCAPES
#endif
-#if APR_HAVE_STDIO_H
#include <stdio.h>
-#endif
-#if APR_HAVE_STRING_H
#include <string.h>
-#endif
+#include <stdio.h>
+#include <ctype.h>
/* A bunch of functions in util.c scan strings looking for certain characters.
* To make that more efficient we encode a lookup table.
@@ -100,15 +81,15 @@
}
#endif
- if (!apr_isalnum(c) && !strchr("$-_.+!*'(),:@&=~", c)) {
+ if (!isalnum(c) && !strchr("$-_.+!*'(),:@&=~", c)) {
flags |= T_ESCAPE_PATH_SEGMENT;
}
- if (!apr_isalnum(c) && !strchr("$-_.+!*'(),:@&=/~", c)) {
+ if (!isalnum(c) && !strchr("$-_.+!*'(),:@&=/~", c)) {
flags |= T_OS_ESCAPE_PATH;
}
- if (!apr_isalnum(c) && !strchr(".-*_ ", c)) {
+ if (!isalnum(c) && !strchr(".-*_ ", c)) {
flags |= T_ESCAPE_URLENCODED;
}
@@ -117,7 +98,7 @@
* backslashes (because we use backslash for escaping)
* and 8-bit chars with the high bit set
*/
- if (c && (!apr_isprint(c) || c == '"' || c == '\\' || apr_iscntrl(c))) {
+ if (c && (!isprint(c) || c == '"' || c == '\\' || iscntrl(c))) {
flags |= T_ESCAPE_ECHO;
}
Regards,
Graham
--
Re: Which of y'all are working on un-APR-izing gen_test_char, and how
will the rest of us know if it is stalled and needs help?
Posted by Jeff Trawick <tr...@gmail.com>.
On Fri, Nov 1, 2013 at 10:05 AM, Jeff Trawick <tr...@gmail.com> wrote:
> TIA!
>
TIA! (ping)
If nobody in the gen_test_char-with-traditional-Windows-build sub-thread
knows what I'm talking about, please let me know. Maybe I am confused
about the planned work.
>
> --
> Born in Roswell... married an alien...
> http://emptyhammock.com/
>
--
Born in Roswell... married an alien...
http://emptyhammock.com/