[GitHub] [kafka] Scanteianu commented on a diff in pull request #13455: KAFKA-14841 Handle callbacks to ConsumerRebalanceListener in MockConsumer

["Scanteianu (via GitHub)" <gi...@apache.org>]

Scanteianu commented on code in PR #13455:
URL: https://github.com/apache/kafka/pull/13455#discussion_r1155081610


##########
clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java:
##########
@@ -92,11 +92,37 @@ public synchronized Set<TopicPartition> assignment() {
         return this.subscriptions.assignedPartitions();
     }
 
-    /** Simulate a rebalance event. */
+    /**
+     * Simulate a rebalance event.
+     */
     public synchronized void rebalance(Collection<TopicPartition> newAssignment) {
-        // TODO: Rebalance callbacks
+        // prepare for rebalance callback

Review Comment:
   thanks - updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org