You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/11/03 16:33:26 UTC
[GitHub] [activemq] mattrpav commented on a diff in pull request #929: AMQ-9157 - Add a new optional advisory for dispatched messages
mattrpav commented on code in PR #929:
URL: https://github.com/apache/activemq/pull/929#discussion_r1013144571
##########
activemq-broker/src/main/java/org/apache/activemq/broker/util/LoggingBrokerPlugin.java:
##########
@@ -526,10 +526,7 @@ public void isFull(ConnectionContext context, Destination destination, Usage<?>
@Override
public void messageConsumed(ConnectionContext context, MessageReference messageReference) {
if (isLogAll() || isLogConsumerEvents() || isLogInternalEvents()) {
- String msg = "Unable to display message.";
Review Comment:
Good clean-up =)
##########
activemq-broker/src/main/java/org/apache/activemq/broker/util/LoggingBrokerPlugin.java:
##########
@@ -538,22 +535,25 @@ public void messageConsumed(ConnectionContext context, MessageReference messageR
@Override
public void messageDelivered(ConnectionContext context, MessageReference messageReference) {
if (isLogAll() || isLogConsumerEvents() || isLogInternalEvents()) {
- String msg = "Unable to display message.";
-
- msg = messageReference.getMessage().toString();
-
+ String msg = messageReference.getMessage().toString();
Review Comment:
Good clean-up =)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org