You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/25 08:30:10 UTC
[GitHub] [flink] gaoyunhaii opened a new pull request #16977: Do not resume channels if the barrier is received via RPC
gaoyunhaii opened a new pull request #16977:
URL: https://github.com/apache/flink/pull/16977
## What is the purpose of the change
This PR tries to fix the issue that for `CheckpointBarrierAligner`, if a barrier is faked due to received checkpoint trigger from RPC but the channel is not finished yet, we should not call resuming channels. If we still resume the channels, since the upstream subpartition is not blocked, there will be exceptions.
The current implementation distinguish if barrier is received from RPC when processing the barrier. Currently I do come up with other better options.
## Brief change log
- 374815385e0790d86e33198354c326d0955d3f38 Modifies the `BarrierHandlerState` implementations so that it support skipping marking channels blocked, then we would not resume the skipped channels on aligned.
- 81b5dd80850a084c70a04a97c3b2879d7fcf5e98 Modifies `processBarrier` to pass the information of whether the barrier is triggered via RPC.
- 1c2ab01420ed2e4d88a74522f0bb611f6d53b751 enhances the test for this case.
## Verifying this change
This change is already covered by the enhanced test.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16977: [FLINK-23938][checkpoint] Do not resume channels if the barrier is received via RPC
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16977:
URL: https://github.com/apache/flink/pull/16977#issuecomment-905314080
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 82579fca34647162573c91ff8751786505aa49ef (Wed Aug 25 08:56:35 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16977: [FLINK-23938][checkpoint] Do not resume channels if the barrier is received via RPC
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16977:
URL: https://github.com/apache/flink/pull/16977#issuecomment-905330052
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82579fca34647162573c91ff8751786505aa49ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22815",
"triggerID" : "82579fca34647162573c91ff8751786505aa49ef",
"triggerType" : "PUSH"
}, {
"hash" : "6d00d40c662c8005211398a2d80d59d900f71f79",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22847",
"triggerID" : "6d00d40c662c8005211398a2d80d59d900f71f79",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6d00d40c662c8005211398a2d80d59d900f71f79 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22847)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #16977: [FLINK-23938][checkpoint] Do not resume channels if the barrier is received via RPC
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #16977:
URL: https://github.com/apache/flink/pull/16977#issuecomment-905598851
Very thanks Piotr @pnowojski for the review! Yes these commits should be squashed~ I squashed the commits and will merge after the azure get green~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16977: [FLINK-23938][checkpoint] Do not resume channels if the barrier is received via RPC
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16977:
URL: https://github.com/apache/flink/pull/16977#issuecomment-905330052
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82579fca34647162573c91ff8751786505aa49ef",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "82579fca34647162573c91ff8751786505aa49ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82579fca34647162573c91ff8751786505aa49ef UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16977: [FLINK-23938][checkpoint] Do not resume channels if the barrier is received via RPC
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16977:
URL: https://github.com/apache/flink/pull/16977#issuecomment-905330052
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82579fca34647162573c91ff8751786505aa49ef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22815",
"triggerID" : "82579fca34647162573c91ff8751786505aa49ef",
"triggerType" : "PUSH"
}, {
"hash" : "6d00d40c662c8005211398a2d80d59d900f71f79",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6d00d40c662c8005211398a2d80d59d900f71f79",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82579fca34647162573c91ff8751786505aa49ef Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22815)
* 6d00d40c662c8005211398a2d80d59d900f71f79 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii closed pull request #16977: [FLINK-23938][checkpoint] Do not resume channels if the barrier is received via RPC
Posted by GitBox <gi...@apache.org>.
gaoyunhaii closed pull request #16977:
URL: https://github.com/apache/flink/pull/16977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16977: [FLINK-23938][checkpoint] Do not resume channels if the barrier is received via RPC
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16977:
URL: https://github.com/apache/flink/pull/16977#issuecomment-905330052
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82579fca34647162573c91ff8751786505aa49ef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22815",
"triggerID" : "82579fca34647162573c91ff8751786505aa49ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82579fca34647162573c91ff8751786505aa49ef Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22815)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16977: [FLINK-23938][checkpoint] Do not resume channels if the barrier is received via RPC
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16977:
URL: https://github.com/apache/flink/pull/16977#issuecomment-905330052
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82579fca34647162573c91ff8751786505aa49ef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22815",
"triggerID" : "82579fca34647162573c91ff8751786505aa49ef",
"triggerType" : "PUSH"
}, {
"hash" : "6d00d40c662c8005211398a2d80d59d900f71f79",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22847",
"triggerID" : "6d00d40c662c8005211398a2d80d59d900f71f79",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82579fca34647162573c91ff8751786505aa49ef Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22815)
* 6d00d40c662c8005211398a2d80d59d900f71f79 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22847)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16977: [FLINK-23938][checkpoint] Do not resume channels if the barrier is received via RPC
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16977:
URL: https://github.com/apache/flink/pull/16977#issuecomment-905330052
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82579fca34647162573c91ff8751786505aa49ef",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22815",
"triggerID" : "82579fca34647162573c91ff8751786505aa49ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82579fca34647162573c91ff8751786505aa49ef Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22815)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org