You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by richard zhou <ri...@intel.com> on 2015/03/05 04:28:05 UTC
Review Request 31757: SQOOP-2172: Move ErrorCode's sub-class from
sqoop-core to sqoop-common
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31757/
-----------------------------------------------------------
Review request for Sqoop and Abraham Elmahrek.
Repository: sqoop-sqoop2
Description
-------
Move ErrorCode.java's sub-class: AuditLoggerError, ConnectorError, CoreError, DriverError, RepositoryError and SecurityError from sqoop-core to sqoop-common
Diffs
-----
common/src/main/java/org/apache/sqoop/error/code/AuditLoggerError.java PRE-CREATION
common/src/main/java/org/apache/sqoop/error/code/ConnectorError.java PRE-CREATION
common/src/main/java/org/apache/sqoop/error/code/CoreError.java PRE-CREATION
common/src/main/java/org/apache/sqoop/error/code/DriverError.java PRE-CREATION
common/src/main/java/org/apache/sqoop/error/code/RepositoryError.java PRE-CREATION
common/src/main/java/org/apache/sqoop/error/code/SecurityError.java PRE-CREATION
core/src/main/java/org/apache/sqoop/audit/AuditLoggerError.java 5999e1c573d46de3a228ae9a5cfcc69f6e818842
core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java 17a996f5f84388280323b5824ed096a51a1f209d
core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java ca9326651ffd9323fe8adc8874c5a7589f13b760
core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb13785799bf3f9df2398dc785ed2719865e
core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java bfdb7b34931489d0bec53f6e96f58cdaad412837
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0907efb3c9a7e40c5cccb470c3a39abf75d7235c
core/src/main/java/org/apache/sqoop/connector/ConnectorManagerUtils.java bd85e997f4871413f33cf39420081825a9dde2e7
core/src/main/java/org/apache/sqoop/core/CoreError.java eb7c1dc5e37eeb1859cf7f63e96919b9db8e8c1b
core/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.java 023fabce170c41ef5096f44048a2e8c56b3851ba
core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java 13bbfc2c02019650b8c91247af6bd939e8cdba7a
core/src/main/java/org/apache/sqoop/driver/DriverError.java 25a1b70f66dfcf7d143c7bd0066e3ebae6c0bdb5
core/src/main/java/org/apache/sqoop/driver/JobManager.java dc441bc2d3d472e061a8324e9a9076b07bace8a1
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 9c5e15e68d83b10a3f0688cf24f24e194bac70fa
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryContext.java 0a8139aaca13925697a31eecf685301189e63f3f
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java 011527f353ed2db3e7f6556c346de6f5b25873f6
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryTransaction.java 86be30ff9e60e6e7f1eddc076a102ceab8db24c7
core/src/main/java/org/apache/sqoop/repository/Repository.java aa91661f846527b7ead52cedd08476500d36cc65
core/src/main/java/org/apache/sqoop/repository/RepositoryError.java f684e85f0ab024bb2cfbb443f4bc5e1bef3889f7
core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java 121f388dc99eb0c74cc8c13b62986c14028405c5
core/src/main/java/org/apache/sqoop/security/SecurityError.java 9f85b9e1110e3f7c94d82a773e7c3d95330ef36f
core/src/main/java/org/apache/sqoop/security/SecurityFactory.java 727d3be2bf01ef1ee628393f3cc70691b23240e4
core/src/test/java/org/apache/sqoop/core/TestSqoopConfiguration.java 956e6abb4d2cb124230a87180b22c1d4961a7b48
core/src/test/java/org/apache/sqoop/driver/TestJobManager.java baca35f99f5173f7b2e8875bd35c5cd17d7ab0bc
core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 9b153fc535e66d34ca8b2d81d28f012619ce8d3d
core/src/test/java/org/apache/sqoop/repository/TestRepositoryManager.java 95b868a92ed2668056f8f17733154035c924e955
security/src/main/java/org/apache/sqoop/security/Authentication/KerberosAuthenticationHandler.java db89a2d592c8fb27588532f3fd716f985b0d1adf
security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthenticationProvider.java 547040b319ce21102ef245df2eb2f86c3a8c4333
server/src/main/java/org/apache/sqoop/filter/SqoopAuthenticationFilter.java ddca9d4e979abd81d99d272d4e8ed02394d75b29
server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java 5562592c9891453b97b46a9767fd54d2f7cca483
server/src/main/java/org/apache/sqoop/server/SqoopProtocolServlet.java 896c60508fef266014e9939e1b60f110761a5c35
test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 9b3babd517fd7b5a1ba2d91fe22d13f87f4387f4
Diff: https://reviews.apache.org/r/31757/diff/
Testing
-------
Thanks,
richard zhou
Re: Review Request 31757: SQOOP-2172: Move ErrorCode's sub-class from
sqoop-core to sqoop-common
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31757/#review75450
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On March 5, 2015, 3:28 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31757/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 3:28 a.m.)
>
>
> Review request for Sqoop and Abraham Elmahrek.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Move ErrorCode.java's sub-class: AuditLoggerError, ConnectorError, CoreError, DriverError, RepositoryError and SecurityError from sqoop-core to sqoop-common
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/error/code/AuditLoggerError.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/error/code/ConnectorError.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/error/code/CoreError.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/error/code/DriverError.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/error/code/RepositoryError.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/error/code/SecurityError.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/audit/AuditLoggerError.java 5999e1c573d46de3a228ae9a5cfcc69f6e818842
> core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java 17a996f5f84388280323b5824ed096a51a1f209d
> core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java ca9326651ffd9323fe8adc8874c5a7589f13b760
> core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb13785799bf3f9df2398dc785ed2719865e
> core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java bfdb7b34931489d0bec53f6e96f58cdaad412837
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0907efb3c9a7e40c5cccb470c3a39abf75d7235c
> core/src/main/java/org/apache/sqoop/connector/ConnectorManagerUtils.java bd85e997f4871413f33cf39420081825a9dde2e7
> core/src/main/java/org/apache/sqoop/core/CoreError.java eb7c1dc5e37eeb1859cf7f63e96919b9db8e8c1b
> core/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.java 023fabce170c41ef5096f44048a2e8c56b3851ba
> core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java 13bbfc2c02019650b8c91247af6bd939e8cdba7a
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 25a1b70f66dfcf7d143c7bd0066e3ebae6c0bdb5
> core/src/main/java/org/apache/sqoop/driver/JobManager.java dc441bc2d3d472e061a8324e9a9076b07bace8a1
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 9c5e15e68d83b10a3f0688cf24f24e194bac70fa
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryContext.java 0a8139aaca13925697a31eecf685301189e63f3f
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java 011527f353ed2db3e7f6556c346de6f5b25873f6
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryTransaction.java 86be30ff9e60e6e7f1eddc076a102ceab8db24c7
> core/src/main/java/org/apache/sqoop/repository/Repository.java aa91661f846527b7ead52cedd08476500d36cc65
> core/src/main/java/org/apache/sqoop/repository/RepositoryError.java f684e85f0ab024bb2cfbb443f4bc5e1bef3889f7
> core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java 121f388dc99eb0c74cc8c13b62986c14028405c5
> core/src/main/java/org/apache/sqoop/security/SecurityError.java 9f85b9e1110e3f7c94d82a773e7c3d95330ef36f
> core/src/main/java/org/apache/sqoop/security/SecurityFactory.java 727d3be2bf01ef1ee628393f3cc70691b23240e4
> core/src/test/java/org/apache/sqoop/core/TestSqoopConfiguration.java 956e6abb4d2cb124230a87180b22c1d4961a7b48
> core/src/test/java/org/apache/sqoop/driver/TestJobManager.java baca35f99f5173f7b2e8875bd35c5cd17d7ab0bc
> core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 9b153fc535e66d34ca8b2d81d28f012619ce8d3d
> core/src/test/java/org/apache/sqoop/repository/TestRepositoryManager.java 95b868a92ed2668056f8f17733154035c924e955
> security/src/main/java/org/apache/sqoop/security/Authentication/KerberosAuthenticationHandler.java db89a2d592c8fb27588532f3fd716f985b0d1adf
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthenticationProvider.java 547040b319ce21102ef245df2eb2f86c3a8c4333
> server/src/main/java/org/apache/sqoop/filter/SqoopAuthenticationFilter.java ddca9d4e979abd81d99d272d4e8ed02394d75b29
> server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java 5562592c9891453b97b46a9767fd54d2f7cca483
> server/src/main/java/org/apache/sqoop/server/SqoopProtocolServlet.java 896c60508fef266014e9939e1b60f110761a5c35
> test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 9b3babd517fd7b5a1ba2d91fe22d13f87f4387f4
>
> Diff: https://reviews.apache.org/r/31757/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> richard zhou
>
>