You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/05/26 10:01:04 UTC
[GitHub] [skywalking-rocketbot-ui] constanine opened a new pull request #497: Fix a bug in the trace statistics page
constanine opened a new pull request #497:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/497
…sorting, as the pictrue, I modify the judgment of the table head column,the column of 'Type' doesn't show the button
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] constanine commented on pull request #497: Fix a bug in the trace statistics page
Posted by GitBox <gi...@apache.org>.
constanine commented on pull request #497:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/497#issuecomment-848639913
> 
> …so sorry, as the pictrue, I modify the judgment of the table head column,the column of 'Type' doesn't show the button
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #497: Fix a bug in the trace statistics page
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #497:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/497#discussion_r639685478
##########
File path: src/views/components/common/trace-chart-table/trace-container.vue
##########
@@ -18,7 +18,7 @@ limitations under the License. -->
<div class="trace-header" v-if="type === 'statistics'">
<div :class="item.label" v-for="(item, index) in headerData" :key="index">
{{ item.value }}
- <span class="r cp" @click="sortStatistics(item.key)" :key="componentKey" v-if="item.key != 'endpointName'">
+ <span class="r cp" @click="sortStatistics(item.key)" :key="componentKey" v-if="(item.key != 'endpointName') & (item.key != 'type')">
Review comment:
```suggestion
<span class="r cp" @click="sortStatistics(item.key)" :key="componentKey" v-if="(item.key != 'endpointName') & (item.key != 'type')">
```
<span class="r cp" @click="sortStatistics(item.key)" :key="componentKey" v-show="(item.key !== 'endpointName') & (item.key !== 'type')">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #497: Fix a bug in the trace statistics page
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #497:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/497#issuecomment-849396888
This feature is still not synced to the main repo. Please sync that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #497: Fix a bug in the trace statistics page
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #497:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/497#discussion_r639685478
##########
File path: src/views/components/common/trace-chart-table/trace-container.vue
##########
@@ -18,7 +18,7 @@ limitations under the License. -->
<div class="trace-header" v-if="type === 'statistics'">
<div :class="item.label" v-for="(item, index) in headerData" :key="index">
{{ item.value }}
- <span class="r cp" @click="sortStatistics(item.key)" :key="componentKey" v-if="item.key != 'endpointName'">
+ <span class="r cp" @click="sortStatistics(item.key)" :key="componentKey" v-if="(item.key != 'endpointName') & (item.key != 'type')">
Review comment:
```suggestion
<span class="r cp" @click="sortStatistics(item.key)" :key="componentKey" v-show="(item.key !== 'endpointName') & (item.key !== 'type')">
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 merged pull request #497: Fix a bug in the trace statistics page
Posted by GitBox <gi...@apache.org>.
Fine0830 merged pull request #497:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #497: Fix a bug in the trace statistics page
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #497:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/497#discussion_r639685478
##########
File path: src/views/components/common/trace-chart-table/trace-container.vue
##########
@@ -18,7 +18,7 @@ limitations under the License. -->
<div class="trace-header" v-if="type === 'statistics'">
<div :class="item.label" v-for="(item, index) in headerData" :key="index">
{{ item.value }}
- <span class="r cp" @click="sortStatistics(item.key)" :key="componentKey" v-if="item.key != 'endpointName'">
+ <span class="r cp" @click="sortStatistics(item.key)" :key="componentKey" v-if="(item.key != 'endpointName') & (item.key != 'type')">
Review comment:
```suggestion
<span class="r cp" @click="sortStatistics(item.key)" :key="componentKey" v-show="(item.key !== 'endpointName') && (item.key !== 'type')">
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] constanine removed a comment on pull request #497: Fix a bug in the trace statistics page
Posted by GitBox <gi...@apache.org>.
constanine removed a comment on pull request #497:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/497#issuecomment-848639913
> 
> …so sorry, as the pictrue, I modify the judgment of the table head column,the column of 'Type' doesn't show the button
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org