[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #5: Add API && Plugin framework registry

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #5:
URL: https://github.com/apache/skywalking-satellite/pull/5#discussion_r534200309



##########
File path: docs/project_structue.md
##########
@@ -0,0 +1,63 @@
+# Project Structure
+- configs: Satellite configs.
+- internal: Core, Api, and common utils.
+- internal/pkg: Sharing with Core and Plugins, such as api and utils.
+- internal/satellite: The core of Satellite.
+- plugins: Contains all plugins.
+- plugins/{type}: Contains the plugins of this {type}. Satellite has 6 plugin types, which are collector, queue, parser, filter, client, and forward.
+- plugins/{type}/define{type}: Contains the plugin define.

Review comment:
       Why need duplicate `{type}`? And define is a verb, usually, a package name is a noun.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org