You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@seata.apache.org by "ggbocoder (via GitHub)" <gi...@apache.org> on 2024/01/06 10:11:44 UTC
[PR] docs: validate that pk is free of comma [incubator-seata-website]
ggbocoder opened a new pull request, #755:
URL: https://github.com/apache/incubator-seata-website/pull/755
## What is the purpose of the change
fixes[issue5136](https://github.com/apache/incubator-seata/issues/5136)
Currently, multiple primary keys are connected by commas on the client side and then separated by commas on the server side. This may lead to incorrect separation if a primary key contains a comma. To mitigate this risk, provide a warning in the documentation and perform validation on the client side.
## Brief changelog
validate that pk is free of comma
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-seata-website/issues) filed for the change(usually before you start working on it). Trivial changes such as typos do not necessitate a GITHUB issue. Your pull request should solely focus on addressing this specific issue without incorporating any other modifications. Each PR should resolve a single issue.
- [ ] Format the pull request title like `doc: add an operations guide document`. Each commit within the pull request should contain a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Test your code locally by running `npm run build`, and make sure it works as expected.
- [ ] Ensure that no files under the `build` folder are included in the commit, as well as the `package-lock.json` and `yarn.lock` files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org
Re: [PR] docs: validate that pk is free of comma [incubator-seata-website]
Posted by "slievrly (via GitHub)" <gi...@apache.org>.
slievrly commented on code in PR #755:
URL: https://github.com/apache/incubator-seata-website/pull/755#discussion_r1444017854
##########
i18n/zh-cn/docusaurus-plugin-content-docs/current/dev/mode/at-mode.md:
##########
@@ -193,7 +193,7 @@ UNDO_LOG Table：不同数据库在类型上会略有差别。
| log_status | tinyint |
| log_created | datetime |
| log_modified | datetime |
-
+> 请确保branche_id中不包含逗号
Review Comment:
Why branch_id as bigint type may contain a comma ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org
Re: [PR] docs: validate that pk is free of comma [incubator-seata-website]
Posted by "slievrly (via GitHub)" <gi...@apache.org>.
slievrly merged PR #755:
URL: https://github.com/apache/incubator-seata-website/pull/755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org
Re: [PR] docs: validate that pk is free of comma [incubator-seata-website]
Posted by "ggbocoder (via GitHub)" <gi...@apache.org>.
ggbocoder commented on code in PR #755:
URL: https://github.com/apache/incubator-seata-website/pull/755#discussion_r1444825819
##########
i18n/zh-cn/docusaurus-plugin-content-docs/current/dev/mode/at-mode.md:
##########
@@ -193,7 +193,7 @@ UNDO_LOG Table：不同数据库在类型上会略有差别。
| log_status | tinyint |
| log_created | datetime |
| log_modified | datetime |
-
+> 请确保branche_id中不包含逗号
Review Comment:
sorry,i made a mistake and i will correct it.Thank you for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org