You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by sv...@apache.org on 2019/08/29 18:44:23 UTC
[wicket] branch master updated: WICKET-6613 don't use null
This is an automated email from the ASF dual-hosted git repository.
svenmeier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/wicket.git
The following commit(s) were added to refs/heads/master by this push:
new edaa76c WICKET-6613 don't use null
edaa76c is described below
commit edaa76c9bcad19bf04b8a90a419f437be75ab2cd
Author: Sven Meier <sv...@apache.org>
AuthorDate: Thu Aug 29 20:43:26 2019 +0200
WICKET-6613 don't use null
as it removes the key and the default height setting will overwrite
---
.../apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
index 808a9e8..7cc3f36 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
@@ -1023,7 +1023,8 @@ public class ModalWindow extends Panel
}
else
{
- settings.put("height", (Object)null);
+ // WICKET-6613 null would remove the key, so use false instead
+ settings.put("height", false);
}
settings.put("resizable", isResizable());