You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/06 06:26:54 UTC
[GitHub] [pulsar-site] michaeljmarshall opened a new pull request, #138: Only replace correctly formed endpoints
michaeljmarshall opened a new pull request, #138:
URL: https://github.com/apache/pulsar-site/pull/138
The current replace.js script leads to malformed output because it converts proper links like `http://pulsar.apache.org/api/client/org/apache/pulsar/client/api/ConsumerConfiguration.html#setPriorityLevel-int-` into `http://pulsar.apache.orghttps://pulsar.apache.org/api/client/2.1.0-incubating/org/apache/pulsar/client/api/ConsumerConfiguration.html#setPriorityLevel-int-`. Instead, we should only replace links when they are properly at the start of a markdown file link, or when they start with a left paren.
You can observe the current behavior and the changed behavior by running `node ./scripts/replace.js` in the `site2/website-next` directory then run `git diff` then grep for `orghttps`. After this change, there are not any malformed links.
```diff
-`priorityLevel` | int | no | Define a [priority](http://pulsar.apache.org/api/client/org/apache/pulsar/client/api/ConsumerConfiguration.html#setPriorityLevel-int-) for the consumer
+`priorityLevel` | int | no | Define a [priority](http://pulsar.apache.orghttps://pulsar.apache.org/api/client/2.1.0-incubating/org/apache/pulsar/client/api/ConsumerConfiguration.html#setPriorityLevel-int-) for the consumer
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] michaeljmarshall commented on pull request #138: Only replace correctly formed endpoints
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #138:
URL: https://github.com/apache/pulsar-site/pull/138#issuecomment-1175837630
Note that in the above comment, the replace script tries to create this link: https://pulsar.apache.org/api/client/2.1.0-incubating/org/apache/pulsar/client/api/ConsumerConfiguration.html#setPriorityLevel-int-. That isn't currently a valid link, and the `ConsumerConfiguration` class is deprecated. http://pulsar.apache.org/api/client/org/apache/pulsar/client/api/ConsumerConfiguration.html#setPriorityLevel-int- is currently valid. We need to address these links before migrating them to be replaced with the `replace.js` script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] urfreespace commented on pull request #138: Only replace correctly formed endpoints
Posted by GitBox <gi...@apache.org>.
urfreespace commented on PR #138:
URL: https://github.com/apache/pulsar-site/pull/138#issuecomment-1175884599
@michaeljmarshall thanks very much, LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] urfreespace merged pull request #138: Only replace correctly formed endpoints
Posted by GitBox <gi...@apache.org>.
urfreespace merged PR #138:
URL: https://github.com/apache/pulsar-site/pull/138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] michaeljmarshall commented on pull request #138: Only replace correctly formed endpoints
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #138:
URL: https://github.com/apache/pulsar-site/pull/138#issuecomment-1175833645
Oops, I included a couple of extra commits in there, I'll overwrite that in just a minute by pushing with force.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org