You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/06 16:48:29 UTC
[GitHub] [tvm] vinx13 opened a new pull request #8939: [AutoScheduler] Fix custom build func in PopenWorker
vinx13 opened a new pull request #8939:
URL: https://github.com/apache/tvm/pull/8939
Fixed an issue introduced in #8492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] shingjan commented on a change in pull request #8939: [AutoScheduler] Fix custom build func in PopenWorker
Posted by GitBox <gi...@apache.org>.
shingjan commented on a change in pull request #8939:
URL: https://github.com/apache/tvm/pull/8939#discussion_r704810605
##########
File path: python/tvm/auto_scheduler/measure.py
##########
@@ -701,7 +700,7 @@ def local_builder_build(inputs, timeout, n_parallel, build_func="default", verbo
[
(
i.serialize(),
- build_func,
+ BuildFunc.build_func,
Review comment:
If we can passing the callable function here, should we also change the type of this argument from `str` to `callable` at line 655?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 merged pull request #8939: [AutoScheduler] Fix custom build func in PopenWorker
Posted by GitBox <gi...@apache.org>.
vinx13 merged pull request #8939:
URL: https://github.com/apache/tvm/pull/8939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on a change in pull request #8939: [AutoScheduler] Fix custom build func in PopenWorker
Posted by GitBox <gi...@apache.org>.
vinx13 commented on a change in pull request #8939:
URL: https://github.com/apache/tvm/pull/8939#discussion_r704811339
##########
File path: python/tvm/auto_scheduler/measure.py
##########
@@ -701,7 +700,7 @@ def local_builder_build(inputs, timeout, n_parallel, build_func="default", verbo
[
(
i.serialize(),
- build_func,
+ BuildFunc.build_func,
Review comment:
Good catch, could you send a PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] shingjan commented on a change in pull request #8939: [AutoScheduler] Fix custom build func in PopenWorker
Posted by GitBox <gi...@apache.org>.
shingjan commented on a change in pull request #8939:
URL: https://github.com/apache/tvm/pull/8939#discussion_r704810605
##########
File path: python/tvm/auto_scheduler/measure.py
##########
@@ -701,7 +700,7 @@ def local_builder_build(inputs, timeout, n_parallel, build_func="default", verbo
[
(
i.serialize(),
- build_func,
+ BuildFunc.build_func,
Review comment:
If we are passing the callable function here, should we also change the type of this argument from `str` to `callable` at line 655?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org