You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/04/01 14:05:42 UTC

[GitHub] [echarts] konrad-amtenbrink opened a new pull request #16825: Changed calculated label gap to be passed from top

konrad-amtenbrink opened a new pull request #16825:
URL: https://github.com/apache/echarts/pull/16825


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   This is just an updated version of this PR: https://github.com/apache/echarts/pull/12236
   Everything here is quoted directly from the mentioned PR.
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x ] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   Is an adapted and working copy of https://github.com/apache/echarts/pull/12236
   Fixes https://github.com/apache/echarts/issues/9265 . Axis.nameGap will be now be calculated upon grid.containLabel: true and axis labels.
   <!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   
   
   
   ### Fixed issues
   
   <!--
   - #xxxx: ...
   -->
   * https://github.com/apache/echarts/issues/9265 xAxis.nameGap and yAxis.nameGap should be set automatically given grid.containLabel
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   For charts with grid.containLabel set to true, axis name could be overlapped with axis labels, if yAxis.nameGap is not manually tweaked.
   
   Here is how echarts behaves by default (quoting: https://github.com/apache/echarts/issues/9265#issuecomment-433346995):
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ### After: How is it fixed in this PR?
   now axis' name will always placed outside grid + axis label rect. nameGap only adds some additional gap.
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ## Misc
   
   <!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
   
   - [ ] The API has been changed (apache/echarts-doc#xxx).
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   N.A.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merging.
   
   ### Other information
   For further information please look at the original PR of @FallenMax


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] konrad-amtenbrink commented on pull request #16825: Changed calculated label gap to be passed from top

Posted by GitBox <gi...@apache.org>.
konrad-amtenbrink commented on pull request #16825:
URL: https://github.com/apache/echarts/pull/16825#issuecomment-1085948435


   Just FYI: I talked to @FallenMax - this is his work - I just made changes to get the PR approved and resolved merge conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #16825: Changed calculated label gap to be passed from top

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #16825:
URL: https://github.com/apache/echarts/pull/16825#issuecomment-1085945696


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org