You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2019/05/30 18:29:11 UTC

[royale-asjs] branch develop updated: Revert "configs-xml: enable abstract classes and private constructors by default since doesn't affect older code. Enablig this exposed 3 classes with no "public" word defined on constructors"

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 620a0a6  Revert "configs-xml: enable abstract classes and private constructors by default since doesn't affect older code. Enablig this exposed 3 classes with no "public" word defined on constructors"
620a0a6 is described below

commit 620a0a6b81ea8b689fce145a0d5e120cc80841db
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Thu May 30 20:28:30 2019 +0200

    Revert "configs-xml: enable abstract classes and private constructors by default since doesn't affect older code. Enablig this exposed 3 classes with no "public" word defined on constructors"
    
    This reverts commit f2a11be724ebe4cb76ef5c2613a1742778dafb31.
---
 frameworks/ace-config-template.xml                                | 8 --------
 frameworks/air-config-template.xml                                | 8 --------
 frameworks/asdoc-config.xml                                       | 8 --------
 frameworks/createjs-config-template.xml                           | 8 --------
 frameworks/flex-config-template.xml                               | 8 --------
 frameworks/jquery-config-template.xml                             | 8 --------
 frameworks/js-config-template.xml                                 | 8 --------
 frameworks/node-config-template.xml                               | 8 --------
 .../org/apache/royale/textLayout/operations/ApplyLinkOperation.as | 2 +-
 .../org/apache/royale/textLayout/operations/CutOperation.as       | 2 +-
 .../royale/textLayout/operations/ModifyInlineGraphicOperation.as  | 2 +-
 frameworks/royale-config-template.xml                             | 8 --------
 12 files changed, 3 insertions(+), 75 deletions(-)

diff --git a/frameworks/ace-config-template.xml b/frameworks/ace-config-template.xml
index 9b96f7a..eb1b412 100644
--- a/frameworks/ace-config-template.xml
+++ b/frameworks/ace-config-template.xml
@@ -325,14 +325,6 @@
       <!-- Possible usage of the ActionScript 2.0 XML class. -->
       <warn-xml-class-has-changed>false</warn-xml-class-has-changed>
 
-      <!-- New AS3 capabilities-->
-      
-        <!-- Allow abstract classes (on by default)-->
-        <allow-abstract-classes>true</allow-abstract-classes>
-        
-        <!-- Allow private constructors (on by default)-->
-        <allow-private-constructors>true</allow-private-constructors>
-        
    </compiler>
 
 
diff --git a/frameworks/air-config-template.xml b/frameworks/air-config-template.xml
index 67771d5..b966740 100644
--- a/frameworks/air-config-template.xml
+++ b/frameworks/air-config-template.xml
@@ -454,14 +454,6 @@
       
       <!-- Possible usage of the ActionScript 2.0 XML class. -->
       <warn-xml-class-has-changed>false</warn-xml-class-has-changed>
-
-      <!-- New AS3 capabilities-->
-      
-        <!-- Allow abstract classes (on by default)-->
-        <allow-abstract-classes>true</allow-abstract-classes>
-        
-        <!-- Allow private constructors (on by default)-->
-        <allow-private-constructors>true</allow-private-constructors>
    
    </compiler>
 
diff --git a/frameworks/asdoc-config.xml b/frameworks/asdoc-config.xml
index 7caba6f..a36470e 100644
--- a/frameworks/asdoc-config.xml
+++ b/frameworks/asdoc-config.xml
@@ -389,14 +389,6 @@
       <!-- Possible usage of the ActionScript 2.0 XML class. -->
       <warn-xml-class-has-changed>false</warn-xml-class-has-changed>
 
-      <!-- New AS3 capabilities-->
-      
-        <!-- Allow abstract classes (on by default)-->
-        <allow-abstract-classes>true</allow-abstract-classes>
-        
-        <!-- Allow private constructors (on by default)-->
-        <allow-private-constructors>true</allow-private-constructors>
-        
    </compiler>
 
    <!-- compute-digest: writes a digest to the catalog.xml of a library. Use this when the library will be used as a
diff --git a/frameworks/createjs-config-template.xml b/frameworks/createjs-config-template.xml
index 29e668d..ec65c34 100644
--- a/frameworks/createjs-config-template.xml
+++ b/frameworks/createjs-config-template.xml
@@ -325,14 +325,6 @@
       <!-- Possible usage of the ActionScript 2.0 XML class. -->
       <warn-xml-class-has-changed>false</warn-xml-class-has-changed>
 
-      <!-- New AS3 capabilities-->
-      
-        <!-- Allow abstract classes (on by default)-->
-        <allow-abstract-classes>true</allow-abstract-classes>
-        
-        <!-- Allow private constructors (on by default)-->
-        <allow-private-constructors>true</allow-private-constructors>
-        
    </compiler>
 
 
diff --git a/frameworks/flex-config-template.xml b/frameworks/flex-config-template.xml
index dc57251..18b45b1 100644
--- a/frameworks/flex-config-template.xml
+++ b/frameworks/flex-config-template.xml
@@ -502,14 +502,6 @@
       <!-- Possible usage of the ActionScript 2.0 XML class. -->
       <warn-xml-class-has-changed>false</warn-xml-class-has-changed>
 
-      <!-- New AS3 capabilities-->
-      
-        <!-- Allow abstract classes (on by default)-->
-        <allow-abstract-classes>true</allow-abstract-classes>
-        
-        <!-- Allow private constructors (on by default)-->
-        <allow-private-constructors>true</allow-private-constructors>
-        
    </compiler>
 
    <!-- compute-digest: writes a digest to the catalog.xml of a library. Use this when the library will be used as a
diff --git a/frameworks/jquery-config-template.xml b/frameworks/jquery-config-template.xml
index 7b2e378..4f2a600 100644
--- a/frameworks/jquery-config-template.xml
+++ b/frameworks/jquery-config-template.xml
@@ -325,14 +325,6 @@
       <!-- Possible usage of the ActionScript 2.0 XML class. -->
       <warn-xml-class-has-changed>false</warn-xml-class-has-changed>
 
-      <!-- New AS3 capabilities-->
-      
-        <!-- Allow abstract classes (on by default)-->
-        <allow-abstract-classes>true</allow-abstract-classes>
-        
-        <!-- Allow private constructors (on by default)-->
-        <allow-private-constructors>true</allow-private-constructors>
-        
    </compiler>
 
 
diff --git a/frameworks/js-config-template.xml b/frameworks/js-config-template.xml
index 795d1ee..971b79d 100644
--- a/frameworks/js-config-template.xml
+++ b/frameworks/js-config-template.xml
@@ -323,14 +323,6 @@
       <!-- Possible usage of the ActionScript 2.0 XML class. -->
       <warn-xml-class-has-changed>false</warn-xml-class-has-changed>
 
-      <!-- New AS3 capabilities-->
-      
-        <!-- Allow abstract classes (on by default)-->
-        <allow-abstract-classes>true</allow-abstract-classes>
-        
-        <!-- Allow private constructors (on by default)-->
-        <allow-private-constructors>true</allow-private-constructors>
-        
    </compiler>
 
 
diff --git a/frameworks/node-config-template.xml b/frameworks/node-config-template.xml
index f58280d..71ad53e 100644
--- a/frameworks/node-config-template.xml
+++ b/frameworks/node-config-template.xml
@@ -324,14 +324,6 @@
       <!-- Possible usage of the ActionScript 2.0 XML class. -->
       <warn-xml-class-has-changed>false</warn-xml-class-has-changed>
 
-      <!-- New AS3 capabilities-->
-      
-        <!-- Allow abstract classes (on by default)-->
-        <allow-abstract-classes>true</allow-abstract-classes>
-        
-        <!-- Allow private constructors (on by default)-->
-        <allow-private-constructors>true</allow-private-constructors>
-        
    </compiler>
 
 
diff --git a/frameworks/projects/TLF/src/main/royale/org/apache/royale/textLayout/operations/ApplyLinkOperation.as b/frameworks/projects/TLF/src/main/royale/org/apache/royale/textLayout/operations/ApplyLinkOperation.as
index 51c47aa..5ff2380 100644
--- a/frameworks/projects/TLF/src/main/royale/org/apache/royale/textLayout/operations/ApplyLinkOperation.as
+++ b/frameworks/projects/TLF/src/main/royale/org/apache/royale/textLayout/operations/ApplyLinkOperation.as
@@ -58,7 +58,7 @@ package org.apache.royale.textLayout.operations
 		 * @playerversion AIR 1.5
 	 	 * @langversion 3.0 
 		 */
-		public function ApplyLinkOperation(operationState:SelectionState, href:String, target:String, extendToLinkBoundary:Boolean)
+		function ApplyLinkOperation(operationState:SelectionState, href:String, target:String, extendToLinkBoundary:Boolean)
 		{
 			super(operationState);
 		
diff --git a/frameworks/projects/TLF/src/main/royale/org/apache/royale/textLayout/operations/CutOperation.as b/frameworks/projects/TLF/src/main/royale/org/apache/royale/textLayout/operations/CutOperation.as
index a2746b5..aa3c89a 100644
--- a/frameworks/projects/TLF/src/main/royale/org/apache/royale/textLayout/operations/CutOperation.as
+++ b/frameworks/projects/TLF/src/main/royale/org/apache/royale/textLayout/operations/CutOperation.as
@@ -55,7 +55,7 @@ package org.apache.royale.textLayout.operations {
 		 * @playerversion AIR 1.5
 	 	 * @langversion 3.0 
 		 */
-		public function CutOperation(operationState:SelectionState, scrapToCut:TextScrap)
+		function CutOperation(operationState:SelectionState, scrapToCut:TextScrap)
 		{
 			super(operationState);
 			if (absoluteStart < absoluteEnd)
diff --git a/frameworks/projects/TLF/src/main/royale/org/apache/royale/textLayout/operations/ModifyInlineGraphicOperation.as b/frameworks/projects/TLF/src/main/royale/org/apache/royale/textLayout/operations/ModifyInlineGraphicOperation.as
index f373800..9b31316 100644
--- a/frameworks/projects/TLF/src/main/royale/org/apache/royale/textLayout/operations/ModifyInlineGraphicOperation.as
+++ b/frameworks/projects/TLF/src/main/royale/org/apache/royale/textLayout/operations/ModifyInlineGraphicOperation.as
@@ -56,7 +56,7 @@ package org.apache.royale.textLayout.operations {
 		 * @playerversion AIR 1.5
 	 	 * @langversion 3.0 
 		 */
-		public function ModifyInlineGraphicOperation(operationState:SelectionState, source:Object, width:Object, height:Object, options:Object = null)
+		function ModifyInlineGraphicOperation(operationState:SelectionState, source:Object, width:Object, height:Object, options:Object = null)
 		{
 			super(operationState);
 							
diff --git a/frameworks/royale-config-template.xml b/frameworks/royale-config-template.xml
index d7a6057..6eb1195 100644
--- a/frameworks/royale-config-template.xml
+++ b/frameworks/royale-config-template.xml
@@ -552,14 +552,6 @@
       <!-- Possible usage of the ActionScript 2.0 XML class. -->
       <warn-xml-class-has-changed>false</warn-xml-class-has-changed>
 
-      <!-- New AS3 capabilities-->
-      
-        <!-- Allow abstract classes (on by default)-->
-        <allow-abstract-classes>true</allow-abstract-classes>
-        
-        <!-- Allow private constructors (on by default)-->
-        <allow-private-constructors>true</allow-private-constructors>
-        
    </compiler>
 
    <!-- compute-digest: writes a digest to the catalog.xml of a library. Use this when the library will be used as a