[jira] [Resolved] (MYFACES-3576) [perf] use get() over eval() for UIViewRoot.getViewId()

["Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>]

     [ https://issues.apache.org/jira/browse/MYFACES-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved MYFACES-3576.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.9
                   2.0.15
    
> [perf] use get() over eval() for UIViewRoot.getViewId()
> -------------------------------------------------------
>
>                 Key: MYFACES-3576
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3576
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: JSR-314
>            Reporter: Leonardo Uribe
>            Assignee: Leonardo Uribe
>            Priority: Trivial
>             Fix For: 2.0.15, 2.1.9
>
>
> Checking some code I saw this line:
>     public String getViewId()
>     {
>         return (String) getStateHelper().eval(PropertyKeys.viewId);
>     }
> A viewId can never be a ValueExpression! The viewId is a value that identifies the view in a unique way and it is set according to the rules of the spec. It is possible to change the line and use get() instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira