[jira] [Work started] (IMPALA-13741) Flake8 warning W504 thrown by critique-gerrit-review.py is incompatible with existing Impala Python code

["Laszlo Gaal (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-13741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on IMPALA-13741 started by Laszlo Gaal.
--------------------------------------------
> Flake8 warning W504 thrown by critique-gerrit-review.py is incompatible with existing Impala Python code
> --------------------------------------------------------------------------------------------------------
>
>                 Key: IMPALA-13741
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13741
>             Project: IMPALA
>          Issue Type: Bug
>            Reporter: Laszlo Gaal
>            Assignee: Laszlo Gaal
>            Priority: Major
>
> The flake8 test pass invoked by bin/jenkins/critique-gerrit-review.py for each new patch submitted for Impala flags occurrences of W504: line break after binary operator.
> According to flake8's documentation, this is a warning that flake8 changed their opinion about in 2016 (see https://www.flake8rules.com/rules/W504.html). Before that date the accepted convention was exactly the opposite: line breaks were accepted _after_ the binary operator.
> Since the majority of Python code in Impala was created before 2016 (first commits for Impala were created in 2011), this code follows with the older convention. Consequently, new Python code added to Impala intends to align with the existing code base, following the old linebreak convention around binary operators.
> IMO critique-gerrit-review.py should respect this convention, and suppress W504 warnings from flake8.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org