You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Edison Su <Ed...@citrix.com> on 2013/10/22 00:26:13 UTC

[Merge]pluggable_vm_snapshot branch

Hi All,
    Per discussion on the thread: http://markmail.org/message/ybw2yy5snkvkuc57, we decide to use coarse-graind interface to make taking vm snapshot pluggable. On pluggable_vm_snapshot, a new interface is added:

public interface VMSnapshotStrategy {
    VMSnapshot takeVMSnapshot(VMSnapshot vmSnapshot);
    boolean deleteVMSnapshot(VMSnapshot vmSnapshot);
    boolean revertVMSnapshot(VMSnapshot vmSnapshot);
    boolean canHandle(VMSnapshot vmSnapshot);
}

Any vendor can implement this interface to customize vm snapshot procedure.
Unit test is added.
If no objection, I'd like to merge it into master. Comments/feedback are welcome, thanks!

RE: [Merge]pluggable_vm_snapshot branch

Posted by Edison Su <Ed...@citrix.com>.

I tested locally with existing marvin test cases: test_vm_snapshots.py on xenserver, it works.

> -----Original Message-----
> From: David Nalley [mailto:david@gnsa.us]
> Sent: Tuesday, October 22, 2013 6:07 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [Merge]pluggable_vm_snapshot branch
> 
> Has any testing been run against this?
> 
> --David
> 
> On Mon, Oct 21, 2013 at 6:26 PM, Edison Su <Ed...@citrix.com> wrote:
> > Hi All,
> >     Per discussion on the thread:
> http://markmail.org/message/ybw2yy5snkvkuc57, we decide to use coarse-
> graind interface to make taking vm snapshot pluggable. On
> pluggable_vm_snapshot, a new interface is added:
> >
> > public interface VMSnapshotStrategy {
> >     VMSnapshot takeVMSnapshot(VMSnapshot vmSnapshot);
> >     boolean deleteVMSnapshot(VMSnapshot vmSnapshot);
> >     boolean revertVMSnapshot(VMSnapshot vmSnapshot);
> >     boolean canHandle(VMSnapshot vmSnapshot); }
> >
> > Any vendor can implement this interface to customize vm snapshot
> procedure.
> > Unit test is added.
> > If no objection, I'd like to merge it into master. Comments/feedback are
> welcome, thanks!

Re: [Merge]pluggable_vm_snapshot branch

Posted by David Nalley <da...@gnsa.us>.

Has any testing been run against this?

--David

On Mon, Oct 21, 2013 at 6:26 PM, Edison Su <Ed...@citrix.com> wrote:
> Hi All,
>     Per discussion on the thread: http://markmail.org/message/ybw2yy5snkvkuc57, we decide to use coarse-graind interface to make taking vm snapshot pluggable. On pluggable_vm_snapshot, a new interface is added:
>
> public interface VMSnapshotStrategy {
>     VMSnapshot takeVMSnapshot(VMSnapshot vmSnapshot);
>     boolean deleteVMSnapshot(VMSnapshot vmSnapshot);
>     boolean revertVMSnapshot(VMSnapshot vmSnapshot);
>     boolean canHandle(VMSnapshot vmSnapshot);
> }
>
> Any vendor can implement this interface to customize vm snapshot procedure.
> Unit test is added.
> If no objection, I'd like to merge it into master. Comments/feedback are welcome, thanks!