You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/22 17:37:58 UTC
[GitHub] [beam] Abacn opened a new pull request, #17447: [BEAM-14357] Fix BigqueryFullResultStreamingMatcher unit test
Abacn opened a new pull request, #17447:
URL: https://github.com/apache/beam/pull/17447
* patch bigquery.Client in test class
**Please** add a meaningful description for your change here
The original patch for '_query_with_retry' actually did not work. BigqueryMatcher._query_with_retry still get called. The test passed because timeout checking passed before the first call of this method. In local machine that runs fast enough, it may still make actual bigquery request and fail.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #17447: [BEAM-14357] Fix BigqueryFullResultStreamingMatcher unit test
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #17447:
URL: https://github.com/apache/beam/pull/17447#issuecomment-1110200235
A github action fails due to [BEAM-14367](https://issues.apache.org/jira/browse/BEAM-14367) not relevant to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17447: [BEAM-14357] Fix BigqueryFullResultStreamingMatcher unit test
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17447:
URL: https://github.com/apache/beam/pull/17447#issuecomment-1106724539
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #17447: [BEAM-14357] Fix BigqueryFullResultStreamingMatcher unit test
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17447:
URL: https://github.com/apache/beam/pull/17447#issuecomment-1110206757
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17447: [BEAM-14357] Fix BigqueryFullResultStreamingMatcher unit test
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17447:
URL: https://github.com/apache/beam/pull/17447#issuecomment-1106724545
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #17447: [BEAM-14357] Fix BigqueryFullResultStreamingMatcher unit test
Posted by GitBox <gi...@apache.org>.
pabloem merged PR #17447:
URL: https://github.com/apache/beam/pull/17447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #17447: [BEAM-14357] Fix BigqueryFullResultStreamingMatcher unit test
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #17447:
URL: https://github.com/apache/beam/pull/17447#issuecomment-1106726349
R: @pabloem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #17447: [BEAM-14357] Fix BigqueryFullResultStreamingMatcher unit test
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #17447:
URL: https://github.com/apache/beam/pull/17447#issuecomment-1106747558
# [Codecov](https://codecov.io/gh/apache/beam/pull/17447?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17447](https://codecov.io/gh/apache/beam/pull/17447?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ef89023) into [master](https://codecov.io/gh/apache/beam/commit/1540b9dccc714d242a51929eac20ced06b1108eb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1540b9d) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #17447 +/- ##
=======================================
Coverage 73.91% 73.91%
=======================================
Files 687 687
Lines 90334 90334
=======================================
Hits 66768 66768
Misses 22382 22382
Partials 1184 1184
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/17447?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/17447?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1540b9d...ef89023](https://codecov.io/gh/apache/beam/pull/17447?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17447: [BEAM-14357] Fix BigqueryFullResultStreamingMatcher unit test
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17447:
URL: https://github.com/apache/beam/pull/17447#issuecomment-1106724544
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org