[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1840: manager-api: Why putting the feature of daemon in core code?

[GitBox <gi...@apache.org>]

bisakhmondal commented on issue #1840:
URL: https://github.com/apache/apisix-dashboard/issues/1840#issuecomment-834726990


   Hi @fregie, sorry to hear that and thank you for elaborating the issue.
   
   The code had been updated keeping 3 things in mind.
   1. Cross-platform support for daemonizing Manager API.
   2. Feature-rich CLI experience. 
   3. And also a good codebase readability. 
   
   If we ignore the service part, it's just a CLI command which invokes the `manageAPI` method which handles the core logic without introducing any service-related stuff. And rest `newxxxCommand` commands are just simple addons subcommand attached with the main CLI command (Actually, it's the way the package `spf13/cobra` works, the CLI management library we are using).
   
   Thanks for the recommendation but I think standalone scripts/service unit files focussed on each OS (Linux, Windows, OSX) would make things even messier. 
   
   >On the other hand, this feature is redundant if it runs in a container.
   
   Freely use `./manager-api` as an entry point :)
   Hope it helps. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org