[pulsar-helm-chart] 20/34: add missing check to dashboard-ingress (helm chart) (#6160)

[si...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git

commit 13dabe6edf5cb525f06fc6bc1d7df6e1f24b6d92
Author: Thomas Memenga <12...@users.noreply.github.com>
AuthorDate: Sat Feb 1 09:07:42 2020 +0100

    add missing check to dashboard-ingress (helm chart) (#6160)
    
    ### Motivation
    
    if you deploy pulsar using the helm chart and disable monitoring with
    
    ```
    extras:
      dashboard: no
    
    ```
    
    but you have the ingress of the dashboard set to true
    
    ```
    dashboard:
      ingress:
        enabled: true
    ```
    
    
    the helm chart will create an ingress that points to a non-existing service because the dashboard itself was not deployed.
    
    
    ### Modifications
    
    I've added the same check that is already in place in dashboard-service and dashboard-deployment
    
    ### Verifying this change
    
    I dont know of any automated tests, i tested it manually. In the end it's the same "if" that is already in place in dashboard-service and dashboard-deployment
    
    
    ### Does this pull request potentially affect one of the following parts:
    
    Affects deployment via helm chart. An unwanted ingress object is suppressed.
    
    ### Documentation
    
     no documentation need
---
 pulsar/templates/dashboard-ingress.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/pulsar/templates/dashboard-ingress.yaml b/pulsar/templates/dashboard-ingress.yaml
index ff9106f..10dc4f9 100644
--- a/pulsar/templates/dashboard-ingress.yaml
+++ b/pulsar/templates/dashboard-ingress.yaml
@@ -17,6 +17,7 @@
 # under the License.
 #
 
+{{- if .Values.extra.dashboard }}
 {{- if .Values.dashboard.ingress.enabled }}
 apiVersion: extensions/v1beta1                                                                                                                                                            
 kind: Ingress                                                                                                                                                                             
@@ -51,3 +52,4 @@ spec:
               serviceName: "{{ template "pulsar.fullname" . }}-{{ .Values.dashboard.component }}"
               servicePort: {{ .Values.dashboard.ingress.port }}
 {{- end }}
+{{- end }}