[GitHub] [pulsar] congbobo184 commented on a diff in pull request #19151: [improve][broker] Add parameter check for create/update cluster.

[GitBox <gi...@apache.org>]

congbobo184 commented on code in PR #19151:
URL: https://github.com/apache/pulsar/pull/19151#discussion_r1064254236


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminTest.java:
##########
@@ -775,7 +773,7 @@ public void resourceQuotas() throws Exception {
         TenantInfoImpl admin = TenantInfoImpl.builder()
                 .allowedClusters(Collections.singleton(cluster))
                 .build();
-        ClusterDataImpl clusterData = ClusterDataImpl.builder().serviceUrl(cluster).build();
+        ClusterDataImpl clusterData = ClusterDataImpl.builder().serviceUrl("http://example.pulsar").build();

Review Comment:
   Is this a breaking change? I haven't reviewed the details.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org