You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "chrisdutz (via GitHub)" <gi...@apache.org> on 2024/08/22 11:55:08 UTC
[PR] Refactor/singleton 1 [iotdb]
chrisdutz opened a new pull request, #13269:
URL: https://github.com/apache/iotdb/pull/13269
## Description
This branch should be used to track the progress of moving away from using singletons.
In a first step I wrote some rules and added a new profile "with-architectural-analysis" that spots Singletons and their usage and reports that.
When building with enabled profile, the JQAssistant plugin will automatically analyse the project and collect all data in a Neo4J database which is located in "target/jqassistant". After the build with
mvn -P with-architectural-analysis jqassistant:report
A nice HTML report can be generated.
When running:
mvn -P with-architectural-analysis jqassistant:server
A Neo4j server is started alongside the Neo4J web-UI. The user can then use the browser to analyse all sort of different things in IoTDB using the Neo4J graph query language: Cypher.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor/singleton 1 [iotdb]
Posted by "liyuheng55555 (via GitHub)" <gi...@apache.org>.
liyuheng55555 commented on PR #13269:
URL: https://github.com/apache/iotdb/pull/13269#issuecomment-2309646909
<img width="1751" alt="image" src="https://github.com/user-attachments/assets/5e26e72c-30d6-42c5-90fd-cd4dd072ad2d">
<img width="1909" alt="image" src="https://github.com/user-attachments/assets/fd51a3d6-f0b2-45b4-b80b-2c8b1be4f608">
@chrisdutz Thanks for the guide, now I find the site dir, and `mvn -P with-architectural-analysis jqassistant:server` is able to connect to the server. By the way, can you provide some example query for neo4j? Chatgpt give me something which seems not working:
```
MATCH (singleton:Type:Singleton)
RETURN singleton
ORDER BY singleton.fqn
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor/singleton 1 [iotdb]
Posted by "liyuheng55555 (via GitHub)" <gi...@apache.org>.
liyuheng55555 commented on PR #13269:
URL: https://github.com/apache/iotdb/pull/13269#issuecomment-2306877123
Hi Chris, I fetched your branch, tried `mvn -P with-architectural-analysis jqassistant:report`, but cannot found the generated html file. Where is this "nice HTML report" located at?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor/singleton 1 [iotdb]
Posted by "liyuheng55555 (via GitHub)" <gi...@apache.org>.
liyuheng55555 commented on PR #13269:
URL: https://github.com/apache/iotdb/pull/13269#issuecomment-2309558264
@chrisdutz still cannot find it... Which package's target directory are you referring to? Besides, I currently only called mvn -P with-architectural-analysis jqassistant:report. Do I need to build the distribution or execute additional commands beyond this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor/singleton 1 [iotdb]
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #13269:
URL: https://github.com/apache/iotdb/pull/13269#issuecomment-2307105145
it should be in "target/site/" something ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor/singleton 1 [iotdb]
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #13269:
URL: https://github.com/apache/iotdb/pull/13269#issuecomment-2309588609
So ... these two steps are needed:
mvn -P with-architectural-analysis clean verify
To collect the data, then:
mvn -P with-architectural-analysis jqassistant:report
To produce the report as seen in my screenshot above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org