You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/05/18 21:18:53 UTC

[GitHub] [ozone] adoroszlai opened a new pull request #2263: HDDS-5242. Skip failing acceptance suite by default

adoroszlai opened a new pull request #2263:
URL: https://github.com/apache/ozone/pull/2263


   ## What changes were proposed in this pull request?
   
   Acceptance tests are split into a few suites, which can be activated by setting `OZONE_ACCEPTANCE_SUITE`.  CI checks execute 3 splits for faster feedback:
   
    * `secure`
    * `unsecure`
    * `misc` + anything without `suite`
   
   There are some other tests, tagged `suite:failing`, which exist only to test the behavior of the acceptance test runner when failures happen.
   
   The goal of this change is to skip the `failing` suite by default, i.e. when acceptance tests are run without suite filter.  This would allow running all tests in sequence (e.g. in nightly job) while retaining the ability to run these special tests by setting `OZONE_ACCEPTANCE_SUITE=failing`.
   
   https://issues.apache.org/jira/browse/HDDS-5242
   
   ## How was this patch tested?
   
   1. Added _bats_ test case.
   2. Ran `test-all.sh` with a small tweak to exit after finding tests.  The output does not include `failing1` or `failing2`:
      ```
      compatibility/test.sh ozone-csi/test.sh ozone-ha/test.sh ozone-mr/test.sh ozone-topology/test.sh ozone/test.sh ozones3-haproxy/test.sh ozonescripts/test.sh ozonesecure-ha/test.sh ozonesecure-mr/test.sh ozonesecure/test.sh restart/test.sh upgrade/test.sh xcompat/test.sh
      ```
      while on `master` it does:
      ```
      compatibility/test.sh failing1/test.sh failing2/test.sh ozone-csi/test.sh ozone-ha/test.sh ozone-mr/test.sh ozone-topology/test.sh ozone/test.sh ozones3-haproxy/test.sh ozonescripts/test.sh ozonesecure-ha/test.sh ozonesecure-mr/test.sh ozonesecure/test.sh restart/test.sh upgrade/test.sh xcompat/test.sh
      ```
   
   https://github.com/adoroszlai/hadoop-ozone/runs/2613248841?check_suite_focus=true#step:4:27
   https://github.com/adoroszlai/hadoop-ozone/actions/runs/853780974


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] elek merged pull request #2263: HDDS-5242. Skip `failing` acceptance suite by default

Posted by GitBox <gi...@apache.org>.
elek merged pull request #2263:
URL: https://github.com/apache/ozone/pull/2263


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on pull request #2263: HDDS-5242. Skip `failing` acceptance suite by default

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2263:
URL: https://github.com/apache/ozone/pull/2263#issuecomment-853012029


   Thanks @elek for reviewing and committing it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org