You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by cd...@apache.org on 2022/11/27 09:08:49 UTC
[submarine] branch master updated: SUBMARINE-1346. Support XGBoost in experiment UI
This is an automated email from the ASF dual-hosted git repository.
cdmikechen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git
The following commit(s) were added to refs/heads/master by this push:
new ed9a9385 SUBMARINE-1346. Support XGBoost in experiment UI
ed9a9385 is described below
commit ed9a938530886aac50fa5b84b3234e65e7c66f27
Author: cdmikechen <cd...@apache.org>
AuthorDate: Mon Nov 21 08:30:41 2022 +0800
SUBMARINE-1346. Support XGBoost in experiment UI
### What is this PR for?
Supplementary XGBoostJob in in experiment UI
### What type of PR is it?
Feature
### Todos
* [x] - Add `Distributed XGBoostJob` tab
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1346
### How should this be tested?
NA
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
Author: cdmikechen <cd...@apache.org>
Signed-off-by: cdmikechen <cd...@apache.org>
Closes #1013 from cdmikechen/SUBMARINE-1346 and squashes the following commits:
aaeefeff [cdmikechen] Commit for python check fix
80b5d699 [cdmikechen] Support XGBoost in experiment UI
---
.../experiment-customized-form.component.html | 10 ++++++++--
.../experiment-customized-form.component.ts | 11 ++++++-----
2 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-form/experiment-customized-form/experiment-customized-form.component.html b/submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-form/experiment-customized-form/experiment-customized-form.component.html
index 5f58663a..649274c3 100644
--- a/submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-form/experiment-customized-form/experiment-customized-form.component.html
+++ b/submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-form/experiment-customized-form/experiment-customized-form.component.html
@@ -169,12 +169,15 @@
</div>
<div *ngSwitchCase="1" id="secondStep">
<nz-radio-group [(ngModel)]="framework" [ngModelOptions]="{ standalone: true }" id="jobs-container">
- <label nz-radio nzValue="Tensorflow" (click)="deleteAllItem(specs); jobTypes = 'Distributed Tensorflow'">
+ <label nz-radio nzValue="Tensorflow" (click)="deleteAllItem(specs); jobTypes='Distributed Tensorflow'">
Distributed Tensorflow
</label>
- <label nz-radio nzValue="Pytorch" (click)="deleteAllItem(specs); jobTypes = 'Distributed Pytorch'">
+ <label nz-radio nzValue="Pytorch" (click)="deleteAllItem(specs); jobTypes='Distributed Pytorch'">
Distributed PyTorch
</label>
+ <label nz-radio nzValue="XGBoost" (click)="deleteAllItem(specs); jobTypes='Distributed XGBoostJob'">
+ Distributed XGBoostJob
+ </label>
<label
nz-radio
nzValue="Standalone"
@@ -199,6 +202,9 @@
<div *ngSwitchCase="'Pytorch'">
<nz-option *ngFor="let spec of PYTORCH_SPECNAMES" [nzValue]="spec" [nzLabel]="spec"></nz-option>
</div>
+ <div *ngSwitchCase="'XGBoost'">
+ <nz-option *ngFor="let spec of XGBOOST_SPECNAMES" [nzValue]="spec" [nzLabel]="spec"></nz-option>
+ </div>
</nz-select>
</div>
<div *ngIf="framework !== 'Standalone'">
diff --git a/submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-form/experiment-customized-form/experiment-customized-form.component.ts b/submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-form/experiment-customized-form/experiment-customized-form.component.ts
index 44202e32..2fd3da1a 100644
--- a/submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-form/experiment-customized-form/experiment-customized-form.component.ts
+++ b/submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-form/experiment-customized-form/experiment-customized-form.component.ts
@@ -57,6 +57,7 @@ export class ExperimentCustomizedFormComponent implements OnInit, OnDestroy {
// Constants
TF_SPECNAMES = ['Master', 'Worker', 'Ps'];
PYTORCH_SPECNAMES = ['Master', 'Worker'];
+ XGBOOST_SPECNAMES = ['Master', 'Worker'];
defaultSpecName = 'worker';
MEMORY_UNITS = ['M', 'G'];
@@ -145,8 +146,8 @@ export class ExperimentCustomizedFormComponent implements OnInit, OnDestroy {
this.subscriptions.push(sub1, sub2);
//TODO: get tags from server
- this.listOfOption = [];
-
+ this.listOfOption = [];
+
}
ngOnDestroy() {
@@ -202,11 +203,11 @@ export class ExperimentCustomizedFormComponent implements OnInit, OnDestroy {
checkStatus() {
if (this.step === 0) {
this.experimentFormService.btnStatusChange(
- this.experimentName.invalid ||
- this.tags.invalid ||
+ this.experimentName.invalid ||
+ this.tags.invalid ||
this.cmd.invalid ||
this.image.invalid ||
- this.envs.invalid
+ this.envs.invalid
);
} else if (this.step === 1) {
this.experimentFormService.btnStatusChange(this.specs.invalid);
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org