You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/01 23:51:59 UTC

[GitHub] [kafka] mjsax commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

mjsax commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418782542



##########
File path: checkstyle/suppressions.xml
##########
@@ -156,7 +156,7 @@
               files="(TopologyBuilder|KafkaStreams|KStreamImpl|KTableImpl|StreamThread|StreamTask).java"/>
 
     <suppress checks="MethodLength"
-              files="(KTableImpl|StreamsPartitionAssignor.java)"/>
+              files="(KTableImpl|StreamsPartitionAssignor|TaskManager).java"/>

Review comment:
       Given the current progress on KIP-447 testing, I would start working on the refactoring next week. _keeping fingers crossed_




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org