You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by nd...@apache.org on 2004/01/03 00:35:59 UTC

cvs commit: httpd-2.0/modules/loggers mod_log_forensic.c

nd          2004/01/02 15:35:59

  Modified:    modules/loggers mod_log_forensic.c
  Log:
  prevent module from segfaulting when not configured.
  
  Revision  Changes    Path
  1.2       +8 -0      httpd-2.0/modules/loggers/mod_log_forensic.c
  
  Index: mod_log_forensic.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/loggers/mod_log_forensic.c,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -u -r1.1 -r1.2
  --- mod_log_forensic.c	1 Jan 2004 15:39:30 -0000	1.1
  +++ mod_log_forensic.c	2 Jan 2004 23:35:59 -0000	1.2
  @@ -222,6 +222,10 @@
       int n;
       apr_status_t rv;
   
  +    if (!cfg->fd) {
  +        return DECLINED;
  +    }
  +
       if (!(id = apr_table_get(r->subprocess_env, "UNIQUE_ID"))) {
           /* we make the assumption that we can't go through all the PIDs in
              under 1 second */
  @@ -269,6 +273,10 @@
       char *s;
       int l,n;
       apr_status_t rv;
  +
  +    if (!cfg->fd) {
  +        return DECLINED;
  +    }
   
       s = apr_pstrcat(r->pool, "-", id, "\n", NULL);
       l = n = strlen(s);
  
  
  

Re: cvs commit: httpd-2.0/modules/loggers mod_log_forensic.c

Posted by Ben Laurie <be...@algroup.co.uk>.
nd@apache.org wrote:

> nd          2004/01/02 15:35:59
> 
>   Modified:    modules/loggers mod_log_forensic.c
>   Log:
>   prevent module from segfaulting when not configured.

Ooops, forgot to bring that forward from 1.3. Thanks.

Cheers,

Ben.

-- 
http://www.apache-ssl.org/ben.html       http://www.thebunker.net/

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff

Re: cvs commit: httpd-2.0/modules/loggers mod_log_forensic.c

Posted by Ben Laurie <be...@algroup.co.uk>.
nd@apache.org wrote:

> nd          2004/01/02 15:35:59
> 
>   Modified:    modules/loggers mod_log_forensic.c
>   Log:
>   prevent module from segfaulting when not configured.

Ooops, forgot to bring that forward from 1.3. Thanks.

Cheers,

Ben.

-- 
http://www.apache-ssl.org/ben.html       http://www.thebunker.net/

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff