You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/07/20 05:33:59 UTC

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #15580: update profiler tutorial

sandeep-krishnamurthy commented on a change in pull request #15580: update profiler tutorial
URL: https://github.com/apache/incubator-mxnet/pull/15580#discussion_r305568441
 
 

 ##########
 File path: docs/tutorials/python/profiler.md
 ##########
 @@ -244,15 +239,17 @@ class CustomAddOneProp(mx.operator.CustomOpProp):
 
 inp = mx.nd.zeros(shape=(500, 500))
 
-profiler.set_config(profile_all=True, continuous_dump = True)
+profiler.set_config(profile_all=True, continuous_dump=True, \
+                   aggregate_stats=True)
 profiler.set_state('run')
 
 w = nd.Custom(inp, op_type="MyAddOne")
 
 mx.nd.waitall()
 
 profiler.set_state('stop')
-profiler.dump()
+print(profiler.dumps())
+profiler.dump(finished=False)
 
 Review comment:
   As mentioned above, for this tutorial and majority of usecase, finished=True?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services