[GitHub] [dubbo-go-hessian2] AlexStocks commented on a change in pull request #204: 解决业务异常无法捕捉的问题

[GitBox <gi...@apache.org>]

AlexStocks commented on a change in pull request #204:
URL: https://github.com/apache/dubbo-go-hessian2/pull/204#discussion_r443214139



##########
File path: java_biz_exception.go
##########
@@ -0,0 +1,63 @@
+package hessian
+
+import (
+	"fmt"

Review comment:
       pls split this import block.

##########
File path: java_biz_exception.go
##########
@@ -0,0 +1,63 @@
+package hessian
+
+import (
+	"fmt"
+	"github.com/apache/dubbo-go-hessian2/java_exception"
+	"sync"
+)
+
+var mutex sync.Mutex

Review comment:
       why add a lonely mutex lock here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org