You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ab...@apache.org on 2021/02/01 00:46:26 UTC
svn commit: r1886087 - in /poi/trunk/src/ooxml:
java/org/apache/poi/xssf/usermodel/XSSFDrawing.java
testcases/org/apache/poi/xssf/usermodel/TestXSSFDrawing.java
Author: abearez
Date: Mon Feb 1 00:46:25 2021
New Revision: 1886087
URL: http://svn.apache.org/viewvc?rev=1886087&view=rev
Log:
Clone only content of imported chart
Modified:
poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDrawing.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDrawing.java
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDrawing.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDrawing.java?rev=1886087&r1=1886086&r2=1886087&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDrawing.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDrawing.java Mon Feb 1 00:46:25 2021
@@ -271,8 +271,7 @@ public final class XSSFDrawing extends P
XSSFClientAnchor destAnchor = new XSSFClientAnchor(from, to);
destAnchor.setAnchorType(ClientAnchor.AnchorType.MOVE_AND_RESIZE);
XSSFChart destChart = createChart(destAnchor);
- destChart.getCTChartSpace().set(srcChart.getCTChartSpace().copy());
- destChart.getCTChart().set(destChart.getCTChartSpace().getChart());
+ destChart.getCTChart().set(srcChart.getCTChartSpace().getChart().copy());
return destChart;
}
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDrawing.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDrawing.java?rev=1886087&r1=1886086&r2=1886087&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDrawing.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDrawing.java Mon Feb 1 00:46:25 2021
@@ -913,6 +913,21 @@ class TestXSSFDrawing {
wb2.close();
}
+ @Test
+ void testBug63901() {
+ XSSFWorkbook workbook = XSSFTestDataSamples.openSampleWorkbook("chartTitle_withTitle.xlsx");
+ XSSFSheet sheet = workbook.getSheet("Sheet1");
+ XSSFDrawing drawing = sheet.createDrawingPatriarch();
+ assert(drawing.getCharts().size() > 0);
+
+ XSSFWorkbook workbook2 = new XSSFWorkbook();
+ XSSFSheet sheet2 = workbook2.createSheet();
+ XSSFDrawing drawing2 = sheet2.createDrawingPatriarch();
+
+ drawing.getCharts().forEach(drawing2::importChart);
+
+ assertEquals(drawing.getCharts().size(), drawing2.getCharts().size());
+ }
private static void checkRewrite(XSSFWorkbook wb) throws IOException {
XSSFWorkbook wb2 = XSSFTestDataSamples.writeOutAndReadBack(wb);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org