You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "JQ-Cao (via GitHub)" <gi...@apache.org> on 2023/07/28 03:52:43 UTC
[GitHub] [incubator-celeborn] JQ-Cao opened a new pull request, #1773: [CELEBORN-852] Adding new metrics to record the number of registered …
JQ-Cao opened a new pull request, #1773:
URL: https://github.com/apache/incubator-celeborn/pull/1773
### What changes were proposed in this pull request?
Adding new metrics to record the number of registered connections
### Why are the changes needed?
Monitor the number of active connections on worker nodes
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1773: [CELEBORN-852] Adding new metrics to record the number of registered …
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1773:
URL: https://github.com/apache/incubator-celeborn/pull/1773#discussion_r1278897422
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/WorkerSource.scala:
##########
@@ -94,6 +95,8 @@ object WorkerSource {
// slots
val SLOTS_ALLOCATED = "SlotsAllocated"
+ val ACTIVE_CONNECTION_COUNT = "ActiveConnectionCount"
Review Comment:
Could you also add this metric in `celeborn-dashboard.json`?
##########
common/src/main/scala/org/apache/celeborn/common/metrics/source/AbstractSource.scala:
##########
@@ -257,6 +257,20 @@ abstract class AbstractSource(conf: CelebornConf, role: String)
}
}
+ override def decCounter(metricsName: String, decV: Long = 1): Unit = {
Review Comment:
Shall we just call `incCounter(xxx, -1)` to achieve this functionality, so we don't need to add these methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1773: [CELEBORN-852] Adding new metrics to record the number of registered …
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1773:
URL: https://github.com/apache/incubator-celeborn/pull/1773#issuecomment-1654965912
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1773?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1773](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1773?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e59fe84) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/5f0295e9f3f1f5781af124ae319e202a2594a103?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5f0295e) will **decrease** coverage by `0.17%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #1773 +/- ##
==========================================
- Coverage 46.81% 46.64% -0.17%
==========================================
Files 162 162
Lines 10012 10019 +7
Branches 923 924 +1
==========================================
- Hits 4686 4672 -14
- Misses 5019 5038 +19
- Partials 307 309 +2
```
| [Files Changed](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...eleborn/common/metrics/source/AbstractSource.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldHJpY3Mvc291cmNlL0Fic3RyYWN0U291cmNlLnNjYWxh) | `34.60% <0.00%> (-1.18%)` | :arrow_down: |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1773/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture closed pull request #1773: [CELEBORN-852] Adding new metrics to record the number of registered …
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #1773: [CELEBORN-852] Adding new metrics to record the number of registered …
URL: https://github.com/apache/incubator-celeborn/pull/1773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org