You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/05 06:18:23 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #25357:
[SPARK-28617][SQL][TEST] Completely remove comments from the golden result
file
HyukjinKwon commented on a change in pull request #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file
URL: https://github.com/apache/spark/pull/25357#discussion_r310450721
##########
File path: sql/core/src/test/resources/sql-tests/results/udf/pgSQL/udf-aggregates_part2.sql.out
##########
@@ -38,14 +35,11 @@ true true false true false true true true true
-- !query 2
SELECT
- -- boolean or transitions
- -- null because strict
Review comment:
Thanks for doing udf-* test cases too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org