You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/01/22 09:41:00 UTC

[jira] [Updated] (FLINK-15691) TaskExecutorPartitionLifecycleTest#runInTaskExecutorThreadAndWait does not run in main thread

     [ https://issues.apache.org/jira/browse/FLINK-15691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated FLINK-15691:
-----------------------------------
    Labels: pull-request-available  (was: )

> TaskExecutorPartitionLifecycleTest#runInTaskExecutorThreadAndWait does not run in main thread
> ---------------------------------------------------------------------------------------------
>
>                 Key: FLINK-15691
>                 URL: https://issues.apache.org/jira/browse/FLINK-15691
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination, Tests
>    Affects Versions: 1.9.1, 1.10.0
>            Reporter: Till Rohrmann
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.11.0
>
>
> The method {{TaskExecutorPartitionLifecycleTest#runInTaskExecutorThreadAndWait}} does not run the given runnable in the {{TaskExecutors}} main thread. Instead it will run it in an arbitrary thread of the {{RpcService}}.
> The reason why this does not cause test instabilities is that we execute operations which don't cause race conditions. However, in order to avoid spreading false friends I would suggest to get rid of this pattern. Moreover, I would question whether {{TaskExecutorPartitionLifecycleTest}} really needs access to the {{TaskExecutors}} internal state. I believe there is an easy way using the {{TaskExecutors}} public API to implement the tests.
> cc [~chesnay], [~azagrebin]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)