You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by Jun Liu <li...@apache.org> on 2018/05/15 03:49:37 UTC
[VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]
Hello Dubbo Community,
This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2.
The release candidates:
https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2 <https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2>/
Git tag for the release:
https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2 <https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2>
Hash for the release tag:
afab04c53edab38d52275d2a198ea1aff7a4f41e
Release Notes:
https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118 <https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118>
The artifacts have been signed with Key : 28681CB1, which can be found in the keys file:
https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS <https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS>
The vote will be open for at least 72 hours or until necessary number of votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Thanks,
The Apache Dubbo (Incubating) Team
Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]
Posted by Ian Luo <ia...@gmail.com>.
+1
This release looks good. We could follow up the minor issues Justin and
others point out in the next release.
Cheers,
-Ian.
On Tue, May 15, 2018 at 11:49 AM Jun Liu <li...@apache.org> wrote:
> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2 <
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2>/
>
> Git tag for the release:
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2 <
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2>
>
> Hash for the release tag:
> afab04c53edab38d52275d2a198ea1aff7a4f41e
>
> Release Notes:
>
> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
> <
> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
> >
>
> The artifacts have been signed with Key : 28681CB1, which can be found in
> the keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS <
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS>
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo (Incubating) Team
Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]
Posted by Yong Zhu <di...@gmail.com>.
+1
All UT passed with JDK 1.8 and JDK 9 on my mac.
Some minor issues I meet:
- When compile sources on JDK 10, a NPE is thrown by
maven-javadoc-plugin:3.0.0, which is a known issue
https://stackoverflow.com/questions/49460751/execution-attach-javadocs-of-goal-org-apache-maven-pluginsmaven-javadoc-plugin
- When run test on JDK 9, the process is interrupted by
maven-checkstyle-plugin:3.0.0 accidentally.
Best regards,
Jerrick
2018-05-18 12:53 GMT+08:00 Jun Liu <li...@apache.org>:
> +1
>
> I have checked that the source release works fine:
> 1. All UT passed with JDK 1.7
> 2. All core features work fine with a certain amount of demos.
> 3. Review passed for changes mentioned in release notes.
>
> Best regards,
> Jun
>
> > On 15 May 2018, at 11:49 AM, Jun Liu <li...@apache.org> wrote:
> >
> > Hello Dubbo Community,
> >
> > This is a call for vote to release Apache Dubbo (Incubating) version
> 2.6.2.
> >
> > The release candidates:
> > https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2 <
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2>/
> >
> > Git tag for the release:
> > https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2 <
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2>
> >
> > Hash for the release tag:
> > afab04c53edab38d52275d2a198ea1aff7a4f41e
> >
> > Release Notes:
> > https://github.com/apache/incubator-dubbo/releases/tag/
> untagged-4775c0a22c60fca55118 <https://github.com/apache/
> incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118>
> >
> > The artifacts have been signed with Key : 28681CB1, which can be found
> in the keys file:
> > https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS <
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS>
> >
> > The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Dubbo (Incubating) Team
>
>
Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]
Posted by Jun Liu <li...@apache.org>.
+1
I have checked that the source release works fine:
1. All UT passed with JDK 1.7
2. All core features work fine with a certain amount of demos.
3. Review passed for changes mentioned in release notes.
Best regards,
Jun
> On 15 May 2018, at 11:49 AM, Jun Liu <li...@apache.org> wrote:
>
> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2 <https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2>/
>
> Git tag for the release:
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2 <https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2>
>
> Hash for the release tag:
> afab04c53edab38d52275d2a198ea1aff7a4f41e
>
> Release Notes:
> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118 <https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118>
>
> The artifacts have been signed with Key : 28681CB1, which can be found in the keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS <https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS>
>
> The vote will be open for at least 72 hours or until necessary number of votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo (Incubating) Team
Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]
Posted by Von Gosling <vo...@apache.org>.
Hi,
+1
I checked:
- name includes incubating
- signatures and hashes correct
- disclaimer exists
- LICENSE and NOTICE correct
- No binary files in release
- Can compile from source
- The binary distribution (with different license and notice files) also looks good.
Some minor problems could be recorded in the next release checklist. Such as, not all source files have apache headers(nat are not always work well), odd unzip file name etc.
Best Regards,
Von Gosling
> 在 2018年5月16日，10:55，Justin Mclean <ju...@classsoftware.com> 写道：
>
> Hi,
>
> +1 (binding)
>
> I checked:
> - Incubating in name
> - Signatures and hashes good
> - DISCLAIMER exists
> - LICENSE and NOTICE good
> - A number of pom.xml and log4j.xml files haven’t had their headers changed to the standard ASF one and are still copyright Alibaba (about 14 files) e.g [4][5]
> - A couple of .sh files are missing ASF headers in [6] also here [9] and here [10]
> - No unexpected binary files in the release
> - Can compile from source
>
> I also checked the binary convenience release and it's all good re signatures, naming, disclaimer, licenses and notice.
>
> Some very minor issues (and IMO except for the MD5 issue) can be fixed next release:
> - Can you remove the MD5 hashes please they are not needed and don’t follow the current release policy. [1]
> - The source unzips into an odd directory name "dubbo-parent-2.6.2”, “apache-dubbo-2.6.2” would be better.
> - The code of conduct may need some small updates for instance I see "dubbo@googlegroups.com” mentioned.
> - The README.md has links to information would be nice to include build instructions inside the README
> - A few poms have some out of date information [2][3]
> - The contributing document need a couple of minor updates (eg @author tags are not used at Apache)
> - LICENSE includes " Copyright (c) 2001-2004 Caucho Technology, Inc” but some of the header have the date range 2001-2008
> - Should these files be in the release? [7][8]
> - Maven check style plugin is taking a long time when compiling (10+minutes) and runs out of memory on my machine. Disabling it (-Dcheckstyle.skip) reduced compile time to under a minute.
>
> I’ve not checked if the compile source actually works (which is sort of important) so might be good if a few people check that when voting +1 :-)
>
> Well done! It's not often I get to vote +1 on the first RC of a first release by a project.
>
> Thanks,
> Justin
>
> 1. https://www.apache.org/dev/release-distribution.html#sigs-and-sums
> 2. ./bom/pom.xml
> 3. ./dependencies-bom/pom.xml
> 4. ./dubbo-rpc/dubbo-rpc-rest/pom.xml
> 5. ./dubbo-common/src/test/resources/log4j.xml
> 6. dubbo-container/dubbo-container-api/src/main/resources/META-INF/assembly/bin/*.sh
> 7. dubbo-rpc/dubbo-rpc-default/dubbo.log
> 8. dubbo-rpc/dubbo-rpc-dubbo/dubbo.log
> 9. dubbo-test/dubbo-test-benchmark/src/main/resources/run.*
> 10. dubbo-test/dubbo-test-benchmark/src/test/resources/server/*.sh
Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
+1 (binding)
I checked:
- Incubating in name
- Signatures and hashes good
- DISCLAIMER exists
- LICENSE and NOTICE good
- A number of pom.xml and log4j.xml files haven’t had their headers changed to the standard ASF one and are still copyright Alibaba (about 14 files) e.g [4][5]
- A couple of .sh files are missing ASF headers in [6] also here [9] and here [10]
- No unexpected binary files in the release
- Can compile from source
I also checked the binary convenience release and it's all good re signatures, naming, disclaimer, licenses and notice.
Some very minor issues (and IMO except for the MD5 issue) can be fixed next release:
- Can you remove the MD5 hashes please they are not needed and don’t follow the current release policy. [1]
- The source unzips into an odd directory name "dubbo-parent-2.6.2”, “apache-dubbo-2.6.2” would be better.
- The code of conduct may need some small updates for instance I see "dubbo@googlegroups.com” mentioned.
- The README.md has links to information would be nice to include build instructions inside the README
- A few poms have some out of date information [2][3]
- The contributing document need a couple of minor updates (eg @author tags are not used at Apache)
- LICENSE includes " Copyright (c) 2001-2004 Caucho Technology, Inc” but some of the header have the date range 2001-2008
- Should these files be in the release? [7][8]
- Maven check style plugin is taking a long time when compiling (10+minutes) and runs out of memory on my machine. Disabling it (-Dcheckstyle.skip) reduced compile time to under a minute.
I’ve not checked if the compile source actually works (which is sort of important) so might be good if a few people check that when voting +1 :-)
Well done! It's not often I get to vote +1 on the first RC of a first release by a project.
Thanks,
Justin
1. https://www.apache.org/dev/release-distribution.html#sigs-and-sums
2. ./bom/pom.xml
3. ./dependencies-bom/pom.xml
4. ./dubbo-rpc/dubbo-rpc-rest/pom.xml
5. ./dubbo-common/src/test/resources/log4j.xml
6. dubbo-container/dubbo-container-api/src/main/resources/META-INF/assembly/bin/*.sh
7. dubbo-rpc/dubbo-rpc-default/dubbo.log
8. dubbo-rpc/dubbo-rpc-dubbo/dubbo.log
9. dubbo-test/dubbo-test-benchmark/src/main/resources/run.*
10. dubbo-test/dubbo-test-benchmark/src/test/resources/server/*.sh
Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]
Posted by Huxing Zhang <hu...@apache.org>.
Hi,
[x] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Details:
* incubator in name
* Disclaimer exists
* sha512 chesum ok
* signature ok
* NOTICE and LICENSE exist in META-INF of jar files of binary release.
* Unit test passed on Java 8 + OSX
Other minor comments:
* The unarchived directory name for
dubbo-incubating-2.6.2-source-release.zip is 'dubbo-parent-2.6.2', may
be better to change to "dubbo-incubating-2.6.2"
* The link[1] to release notes is not accessible, should be [2], and
it is inaccessible to non-committer, maybe it is better to attach them
to the voting thread.
* dubbo-parent seems took 23+ min in my local environment, I checked
the jstack and it looks like maven-checkstyle-plugin is scanning
directories..
[1] https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
[2] https://github.com/apache/incubator-dubbo/releases/tag/untagged-616b91e8d915fe71a17f
On Tue, May 15, 2018 at 11:49 AM, Jun Liu <li...@apache.org> wrote:
> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2 <https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2>/
>
> Git tag for the release:
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2 <https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2>
>
> Hash for the release tag:
> afab04c53edab38d52275d2a198ea1aff7a4f41e
>
> Release Notes:
> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118 <https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118>
>
> The artifacts have been signed with Key : 28681CB1, which can be found in the keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS <https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS>
>
> The vote will be open for at least 72 hours or until necessary number of votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo (Incubating) Team
--
Best Regards！
Huxing
Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]
Posted by jun liu <ke...@gmail.com>.
Hi Justin,
> Hash for the release tag:
> afab04c53edab38d52275d2a198ea1aff7a4f41e
It’s included in the initial vote email.
> On 16 May 2018, at 10:44 AM, Justin Mclean <ju...@classsoftware.com> wrote:
>
> HI,
>
>> I don’t think we need to change the release tag hash. Tag ‘dubbo-2.6.2’ has never changed, so the source release, binary release and the release tag are still in consistent to each other. Be aware that CHANGES.md only exists in the ‘2.6.2-release’ branch, a branch we used for release purpose, it serves for the release process but not bounded.
>
> As tags are mutable in git it best to specify the hash in the release vote email (ie afab04c).
>
> Thanks,
> Justin
Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]
Posted by Justin Mclean <ju...@classsoftware.com>.
HI,
> I don’t think we need to change the release tag hash. Tag ‘dubbo-2.6.2’ has never changed, so the source release, binary release and the release tag are still in consistent to each other. Be aware that CHANGES.md only exists in the ‘2.6.2-release’ branch, a branch we used for release purpose, it serves for the release process but not bounded.
As tags are mutable in git it best to specify the hash in the release vote email (ie afab04c).
Thanks,
Justin
Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]
Posted by jun liu <ke...@gmail.com>.
>>> Release Notes:
>>> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118 <https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118>
>>
>> Sorry, the previous link seems invisible for non-committers, please check the following link for detailed release notes:
>> https://github.com/apache/incubator-dubbo/blob/2.6.2-release/CHANGES.md <https://github.com/apache/incubator-dubbo/blob/2.6.2-release/CHANGES.md>
>
> Since you pushed to the release branch, the hash for the release tag
> should also be changed?
I don’t think we need to change the release tag hash. Tag ‘dubbo-2.6.2’ has never changed, so the source release, binary release and the release tag are still in consistent to each other. Be aware that CHANGES.md only exists in the ‘2.6.2-release’ branch, a branch we used for release purpose, it serves for the release process but not bounded.
Best regards,
Jun
> On 15 May 2018, at 3:38 PM, Huxing Zhang <hu...@apache.org> wrote:
>
> On Tue, May 15, 2018 at 2:11 PM, Jun Liu <liujun@apache.org <ma...@apache.org>> wrote:
>>> Release Notes:
>>> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118 <https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118>
>>
>> Sorry, the previous link seems invisible for non-committers, please check the following link for detailed release notes:
>> https://github.com/apache/incubator-dubbo/blob/2.6.2-release/CHANGES.md <https://github.com/apache/incubator-dubbo/blob/2.6.2-release/CHANGES.md>
>
> Since you pushed to the release branch, the hash for the release tag
> should also be changed?
>
>>
>>> On 15 May 2018, at 11:49 AM, Jun Liu <li...@apache.org> wrote:
>>>
>>> Hello Dubbo Community,
>>>
>>> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2.
>>>
>>> The release candidates:
>>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2/
>>>
>>> Git tag for the release:
>>> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2
>>>
>>> Hash for the release tag:
>>> afab04c53edab38d52275d2a198ea1aff7a4f41e
>>>
>>> Release Notes:
>>> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
>>>
>>> The artifacts have been signed with Key : 28681CB1, which can be found in the keys file:
>>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>>>
>>> The vote will be open for at least 72 hours or until necessary number of votes are reached.
>>>
>>> Please vote accordingly:
>>>
>>> [ ] +1 approve
>>> [ ] +0 no opinion
>>> [ ] -1 disapprove with the reason
>>>
>>> Thanks,
>>> The Apache Dubbo (Incubating) Team
>>
>
> --
> Best Regards！
> Huxing
Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]
Posted by Huxing Zhang <hu...@apache.org>.
On Tue, May 15, 2018 at 2:11 PM, Jun Liu <li...@apache.org> wrote:
>> Release Notes:
>> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
>
> Sorry, the previous link seems invisible for non-committers, please check the following link for detailed release notes:
> https://github.com/apache/incubator-dubbo/blob/2.6.2-release/CHANGES.md
Since you pushed to the release branch, the hash for the release tag
should also be changed?
>
>> On 15 May 2018, at 11:49 AM, Jun Liu <li...@apache.org> wrote:
>>
>> Hello Dubbo Community,
>>
>> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2.
>>
>> The release candidates:
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2/
>>
>> Git tag for the release:
>> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2
>>
>> Hash for the release tag:
>> afab04c53edab38d52275d2a198ea1aff7a4f41e
>>
>> Release Notes:
>> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
>>
>> The artifacts have been signed with Key : 28681CB1, which can be found in the keys file:
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>>
>> The vote will be open for at least 72 hours or until necessary number of votes are reached.
>>
>> Please vote accordingly:
>>
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove with the reason
>>
>> Thanks,
>> The Apache Dubbo (Incubating) Team
>
--
Best Regards！
Huxing
Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]
Posted by Jun Liu <li...@apache.org>.
> Release Notes:
> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
Sorry, the previous link seems invisible for non-committers, please check the following link for detailed release notes:
https://github.com/apache/incubator-dubbo/blob/2.6.2-release/CHANGES.md
> On 15 May 2018, at 11:49 AM, Jun Liu <li...@apache.org> wrote:
>
> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2/
>
> Git tag for the release:
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2
>
> Hash for the release tag:
> afab04c53edab38d52275d2a198ea1aff7a4f41e
>
> Release Notes:
> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
>
> The artifacts have been signed with Key : 28681CB1, which can be found in the keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo (Incubating) Team