You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Piyush Hari (JIRA)" <ad...@incubator.apache.org> on 2006/09/11 09:59:24 UTC
[jira] Created: (ADFFACES-173) 'initialFocusId' attribute support
for document component on PDA
'initialFocusId' attribute support for document component on PDA
------------------------------------------------------------------
Key: ADFFACES-173
URL: http://issues.apache.org/jira/browse/ADFFACES-173
Project: MyFaces ADF-Faces
Issue Type: Improvement
Environment: PDA
Reporter: Piyush Hari
Priority: Minor
'initialFocusId' attribute on a 'document' component represents the id of the component to which you want the focus to be when the full page renders. This attribute is currently not supported on PDAs but works fine for desktop applications. We plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-173) 'initialFocusId' attribute support
for document component on PDA
Posted by "Piyush Hari (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-173?page=all ]
Piyush Hari updated ADFFACES-173:
---------------------------------
Attachment: patch_sept19_05_10PM.patch
This patch is the latest. It includes what Adam suggested in the last comment.
> 'initialFocusId' attribute support for document component on PDA
> -----------------------------------------------------------------
>
> Key: ADFFACES-173
> URL: http://issues.apache.org/jira/browse/ADFFACES-173
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_sept14_12_43PM.patch, patch_sept19_05_10PM.patch
>
>
> 'initialFocusId' attribute on a 'document' component represents the id of the component to which you want the focus to be when the full page renders. This attribute is currently not supported on PDAs but works fine for desktop applications. We plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-173) 'initialFocusId' attribute
support for document component on PDA
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-173?page=comments#action_12435910 ]
Adam Winer commented on ADFFACES-173:
-------------------------------------
Comments on the patch:
- We should avoid checking agent types whereever possible in our rendering code; so only rendering _checkLoadNoPPR() on Blackberry is a problem; it should be rendered for all non-PPR browsers.
- Can't we move the check for event being undefined into the JS? That is, "if (!event) event=window.event;" Don't put it in BodyRenderer.
- Instead of checking "isBlackberry" before calling getElementById(), check if document.getElementById exists.
> 'initialFocusId' attribute support for document component on PDA
> -----------------------------------------------------------------
>
> Key: ADFFACES-173
> URL: http://issues.apache.org/jira/browse/ADFFACES-173
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_sept14_12_43PM.patch
>
>
> 'initialFocusId' attribute on a 'document' component represents the id of the component to which you want the focus to be when the full page renders. This attribute is currently not supported on PDAs but works fine for desktop applications. We plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-173) 'initialFocusId' attribute support
for document component on PDA
Posted by "Piyush Hari (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-173?page=all ]
Piyush Hari updated ADFFACES-173:
---------------------------------
Attachment: patch_sept19_05_01PM.patch
I am attaching the new patch which contains the patch in response to Adam's three suggestions. They are all contained. Please review.
> 'initialFocusId' attribute support for document component on PDA
> -----------------------------------------------------------------
>
> Key: ADFFACES-173
> URL: http://issues.apache.org/jira/browse/ADFFACES-173
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_sept14_12_43PM.patch
>
>
> 'initialFocusId' attribute on a 'document' component represents the id of the component to which you want the focus to be when the full page renders. This attribute is currently not supported on PDAs but works fine for desktop applications. We plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (ADFFACES-173) 'initialFocusId' attribute support
for document component on PDA
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-173?page=all ]
Jeanne Waldman reassigned ADFFACES-173:
---------------------------------------
Assignee: Jeanne Waldman
> 'initialFocusId' attribute support for document component on PDA
> -----------------------------------------------------------------
>
> Key: ADFFACES-173
> URL: http://issues.apache.org/jira/browse/ADFFACES-173
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Assigned To: Jeanne Waldman
> Priority: Minor
> Attachments: patch_sept14_12_43PM.patch, patch_sept19_05_10PM.patch, patch_sept27_10_32AM_initialFocusId.patch
>
>
> 'initialFocusId' attribute on a 'document' component represents the id of the component to which you want the focus to be when the full page renders. This attribute is currently not supported on PDAs but works fine for desktop applications. We plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-173) 'initialFocusId' attribute support
for document component on PDA
Posted by "Piyush Hari (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-173?page=all ]
Piyush Hari updated ADFFACES-173:
---------------------------------
Attachment: patch_sept14_12_43PM.patch
I am providing patch for this issue. With this patch, 'initialFocusId' will work on BlackBerry, PIE and IE Mobile. The following major changes were made:
- onload JS handler for body html tag currently calls _checkLoad(event) method for all browsers that supports PPR. 'event' argument was causing an error to appear on PIE and IE Mobile. Moreover, 'event' was not used in _checkLoad(event) method definition. Therefore, I removed it.
-_checkLoad sets the initialFocus. However, it is called for only those browsers that support PPR. For others, that do not, like BlackBerry 4.0+ , no onload JS handler for body html tag is called. Thus, intialFocus is not set. Therefore, created a _checkLoadNoPPR() function to set focus.
-other code improvements : see comments in patch to review other important code changes.
> 'initialFocusId' attribute support for document component on PDA
> -----------------------------------------------------------------
>
> Key: ADFFACES-173
> URL: http://issues.apache.org/jira/browse/ADFFACES-173
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_sept14_12_43PM.patch
>
>
> 'initialFocusId' attribute on a 'document' component represents the id of the component to which you want the focus to be when the full page renders. This attribute is currently not supported on PDAs but works fine for desktop applications. We plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-173) 'initialFocusId' attribute support
for document component on PDA
Posted by "Piyush Hari (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-173?page=all ]
Piyush Hari updated ADFFACES-173:
---------------------------------
Attachment: (was: patch_sept19_05_01PM.patch)
> 'initialFocusId' attribute support for document component on PDA
> -----------------------------------------------------------------
>
> Key: ADFFACES-173
> URL: http://issues.apache.org/jira/browse/ADFFACES-173
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_sept14_12_43PM.patch
>
>
> 'initialFocusId' attribute on a 'document' component represents the id of the component to which you want the focus to be when the full page renders. This attribute is currently not supported on PDAs but works fine for desktop applications. We plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-173) 'initialFocusId' attribute support
for document component on PDA
Posted by "Piyush Hari (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-173?page=all ]
Piyush Hari updated ADFFACES-173:
---------------------------------
Comment: was deleted
> 'initialFocusId' attribute support for document component on PDA
> -----------------------------------------------------------------
>
> Key: ADFFACES-173
> URL: http://issues.apache.org/jira/browse/ADFFACES-173
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_sept14_12_43PM.patch
>
>
> 'initialFocusId' attribute on a 'document' component represents the id of the component to which you want the focus to be when the full page renders. This attribute is currently not supported on PDAs but works fine for desktop applications. We plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-173) 'initialFocusId' attribute support
for document component on PDA
Posted by "Piyush Hari (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-173?page=all ]
Piyush Hari updated ADFFACES-173:
---------------------------------
Attachment: patch_sept27_10_32AM_initialFocusId.patch
I am providing a patch which includes suggestions by Jeanne. (patch_sept27_10_32AM_initialFocusId.patch). _getEventObj is called from Javascript and not from BodyRenderer anymore.
> 'initialFocusId' attribute support for document component on PDA
> -----------------------------------------------------------------
>
> Key: ADFFACES-173
> URL: http://issues.apache.org/jira/browse/ADFFACES-173
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_sept14_12_43PM.patch, patch_sept19_05_10PM.patch, patch_sept27_10_32AM_initialFocusId.patch
>
>
> 'initialFocusId' attribute on a 'document' component represents the id of the component to which you want the focus to be when the full page renders. This attribute is currently not supported on PDAs but works fine for desktop applications. We plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-173) 'initialFocusId' attribute support
for document component on PDA
Posted by "Piyush Hari (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-173?page=all ]
Piyush Hari updated ADFFACES-173:
---------------------------------
Status: Patch Available (was: Open)
> 'initialFocusId' attribute support for document component on PDA
> -----------------------------------------------------------------
>
> Key: ADFFACES-173
> URL: http://issues.apache.org/jira/browse/ADFFACES-173
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_sept14_12_43PM.patch
>
>
> 'initialFocusId' attribute on a 'document' component represents the id of the component to which you want the focus to be when the full page renders. This attribute is currently not supported on PDAs but works fine for desktop applications. We plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-173) 'initialFocusId' attribute
support for document component on PDA
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-173?page=comments#action_12437977 ]
Jeanne Waldman commented on ADFFACES-173:
-----------------------------------------
Can't you call _getEventObj from within the javascript instead of adding it to the rendered html?
onunload = XhtmlUtils.getChainedJS("var eventObj = _getEventObj(); _checkUnload(eventObj);",
onunload,
false);
> 'initialFocusId' attribute support for document component on PDA
> -----------------------------------------------------------------
>
> Key: ADFFACES-173
> URL: http://issues.apache.org/jira/browse/ADFFACES-173
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Priority: Minor
> Attachments: patch_sept14_12_43PM.patch, patch_sept19_05_10PM.patch
>
>
> 'initialFocusId' attribute on a 'document' component represents the id of the component to which you want the focus to be when the full page renders. This attribute is currently not supported on PDAs but works fine for desktop applications. We plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-173) 'initialFocusId' attribute support
for document component on PDA
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-173?page=all ]
Jeanne Waldman updated ADFFACES-173:
------------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
committed for Piyush.
> 'initialFocusId' attribute support for document component on PDA
> -----------------------------------------------------------------
>
> Key: ADFFACES-173
> URL: http://issues.apache.org/jira/browse/ADFFACES-173
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Environment: PDA
> Reporter: Piyush Hari
> Assigned To: Jeanne Waldman
> Priority: Minor
> Attachments: patch_sept14_12_43PM.patch, patch_sept19_05_10PM.patch, patch_sept27_10_32AM_initialFocusId.patch
>
>
> 'initialFocusId' attribute on a 'document' component represents the id of the component to which you want the focus to be when the full page renders. This attribute is currently not supported on PDAs but works fine for desktop applications. We plan to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-173) 'initialFocusId' attribute support
for document component on PDA
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated ADFFACES-173:
----------------------------------------
Fix Version/s: 1.0.0-incubating-core
Affects Version/s: 1.0.0-incubating-core
> 'initialFocusId' attribute support for document component on PDA
> -----------------------------------------------------------------
>
> Key: ADFFACES-173
> URL: https://issues.apache.org/jira/browse/ADFFACES-173
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Affects Versions: 1.0.0-incubating-core
> Environment: PDA
> Reporter: Piyush Hari
> Assigned To: Jeanne Waldman
> Priority: Minor
> Fix For: 1.0.0-incubating-core
>
> Attachments: patch_sept14_12_43PM.patch, patch_sept19_05_10PM.patch, patch_sept27_10_32AM_initialFocusId.patch
>
>
> 'initialFocusId' attribute on a 'document' component represents the id of the component to which you want the focus to be when the full page renders. This attribute is currently not supported on PDAs but works fine for desktop applications. We plan to fix this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.